Success message on requisition submit even when the submit fails

Description

I've skipped all line items and attempted to submit the requisition. The backend rejected the submit, since the requisition must contain at least one not skipped line item, however UI has shown a success message despite the failure in the backend (see attached screenshot). We should show a proper message when there's an attempt to do so. Also in no case should the UI show success message despite backend failing.

Acceptance criteria:

  • A proper error message is displayed when I click submit with all line items skipped

  • If a request to the backend server fails - no success message is displayed

Environment

None

Activity

Show:
Sebastian Brudziński
February 20, 2017, 1:49 PM

FYI
Please take a look and help determine how important this is & whether we should/shouldn't be able to submit a requisition with all line items skipped. We probably have enough capacity to include this in the sprint if needed.

Paweł Gesek
February 20, 2017, 3:19 PM
Edited

is this an issue with our error handling in general?

Sebastian Brudziński
February 20, 2017, 3:27 PM

Not sure. It looks like it may be.

Mary Jo Kochendorfer
February 20, 2017, 6:17 PM

The backend behavior is correct. We should have correct error messaging. If we can fit this into the sprint it would be good, but I'd put it down the priority list.

Paulina Borowa
February 28, 2017, 2:38 PM

Now when user tries to submit requisition with skipped all line items he get notification: "Cannot submit requisition with all line items skipped."

Assignee

Sebastian Brudziński

Reporter

Sebastian Brudziński

Labels

None

Story Points

3

Time tracking

0m

Time remaining

0m

Components

Sprint

None

Fix versions

Priority

Minor
Configure