Offline Login modal error

Description

When a user is offline and tries to login they should receive a message that says "Cannot complete this action while offline". When the message is cleared and they are still offline, they should still receive the same error message. Currently the login modal shows them an Invalid login error. This is confusing for the user.

Steps to Reproduce:
Go offline
Try to log in to test.openlmis.org
Error message appears on login modal that password is incorrect.

Expected behavior:
When user is offline, they should receive a message that the system is offline, or the login modal shows offline.
Suggestion from Ben:

Error State

UI message

Bad User Credentials

"The username or password you entered is incorrect. Please try again."

Request Timeout

"Could not connect to server. Please try again later."

Anything Else

"Unknown server error. Please contact your OpenLMIS administrator.”

Environment

None

Activity

Show:
Mateusz Kwiatkowski
August 25, 2017, 9:05 AM

I'm OK with those changes, probably opinion would be nice to hear.
But decision should be made by or I guess?
I've moved this one to QA for now, if we will decide on changing ACC we can reopen it.

Mary Jo Kochendorfer
August 25, 2017, 10:19 PM

, It is my understanding that the confusion is that when a user is looking at the login modal

and tries to login... the current error message comes back with password errors versus telling the user the issue is that they are offline. I am okay with only adding the more detailed error message telling the user they are offline. In the future we could look to disable or visually show the user that they are offline and cannot use the "sign in" button.

Joanna Bebak
August 29, 2017, 12:10 PM

I checked, and now a modal with a correct error message occurs when one tries to log in without Internet connection.

Paweł Gesek
August 29, 2017, 1:37 PM

what is the root cause for this bug?

Mateusz Kwiatkowski
August 29, 2017, 1:43 PM

I didn't put bug root cause analysis because it is not a bug really. I've just added new message if user tries to log in offline.
Maybe only cause was removal of logging offline functionality and not adding new message for offline state, but there was no requirements like this before.

Done

Assignee

Mateusz Kwiatkowski

Reporter

Sam Im

Labels

None

Story Points

3

Time tracking

0m

Time remaining

12h 30m

Components

Sprint

None

Fix versions

Affects versions

Priority

Major