Move open-external-url file from Malawi to the core

Description

MW-435:
Things that need to be done here:

  • Add documentation to this file file

  • Add unit tests

  • Move file and its tests to the core project by creating the pull request

  • Remove it from the Malawi implementation

Acceptance criteria:

  • Added unit tests are carried out during build and their result is successful

  • Documentation added to the file is visible in docs

  • Pull request to the core project is merged

  • All files moved to the core are removed from Malawi project

Activity

Show:
Joanna Bebak
August 11, 2017, 12:09 PM

I made a re-test, and now all acceptance criteria are met.

Paweł Gesek
August 11, 2017, 1:03 PM

how can this be showcased? Is this used anywhere? By the way I am not extremely clear on what this does - is it for opening external urls in separate tabs?

Joanna Bebak
August 11, 2017, 1:07 PM

I'm not sure if it can be showcased at all because it's just the addition of a file and unit tests to the repository, and of the documentation. But maybe Weronika has an idea.

Weronika Ciecierska
August 11, 2017, 1:07 PM

This is used only in Malawi right now, so in the core it cannot be showcased other than showing docs and tests.
Here is example how it works: http://build.openlmis.org/job/OpenLMIS-reference-ui/lastSuccessfulBuild/artifact/build/docs/index.html#/api/openlmis-external-url.run:openExternalUrl - basicaly you add "externalUrl" to the state and then it opens link provided in this property in the new tab.
You can see it in work in Malawi "Contact support" tab visible on dev server - it opens Malawi service desk in the new tab.

Paweł Gesek
August 11, 2017, 1:44 PM

Ok thanks

Done

Assignee

Paweł Gesek

Reporter

Weronika Ciecierska

Labels

None

Story Points

2

Time tracking

0m

Time remaining

13h 30m

Sprint

None

Fix versions

Priority

Major