Issues with error messages on the Stock Adjustments screen

Description

During the execution of OLMIS-2914, I noticed issues with error messages on the "Adjustments" screen.

1. According to the test case, after clicking on a table field with no data entered, and then, tabbing or clicking on another element in the same row, no error message should appear for the row. Yet on the "Adjustments" screen, an error shows in pagination after clicking on the "Quantity" field without any data and moving to another field.

2. Also, after clicking or tabbing outside the required table field without any data, an error message should occur. But in such a situation, the "Quantity" field doesn't get marked as required - the exclamation mark doesn't appear.

Reproduction steps for #1

1. Log in as srmanager2.
2. Go to Stock Management > Adjustments.
3. Click the "Make Adjustments" button next to Family Planning.
4. Add any product, e.g. Levora.
5. Click on the "Quantity" field.
6. Tab to the "Date" field.
7. The pagination changes color to red.

Reproduction steps for #2

1. Log in as srmanager2.
2. Go to Stock Management > Adjustments.
3. Click the "Make Adjustments" button next to Family Planning.
4. Add any product, e.g. Levora.
5. Click on the "Quantity" field.
6. Click outside the field.
7. The pagination changes color to red but the exclamation mark doesn't appear in the "Quantity" field.

Acceptance Criteria

  • The error behavior on this screen should be consistent and it should match the behavior of the product grid on the requisition view screen.

Environment

None

Activity

Show:
Joanna Bebak
April 17, 2018, 11:10 AM

Thanks for adding the changelog and resolving my doubts. I'll close the ticket then.

Nikodem Graczewski
April 17, 2018, 10:28 AM

I've added the changelog.

Paweł Albecki
April 17, 2018, 10:17 AM

If some regression was fixed, why wouldn't we add changelog? We will get rid of it after release, so these changes will be part of 3.3.0?

Nikodem Graczewski
April 17, 2018, 9:58 AM


1. I wouldn't add a changelog for this as we wan't to get rid of it right after the release. Could you confirm ?
2. If the form can be submitted then it is not required.

Joanna Bebak
April 17, 2018, 9:53 AM

I tested the ticket and have two questions:
1. Is a changelog necessary in the case of changes introduced by this ticket? If so, please add one because it is missing.
2. Is "VVM Status" a required field? I'm asking about it because no error occurs when one makes a selection and then, clears the field, or when one leaves it blank and clicks "Submit" when e.g. adding an adjustment for Streptococcus Pneumoniae Vaccine with VVM for Comfort Health Clinic and Essential Meds. If the field is not required, everything works correctly, and I will close the ticket.

Done

Assignee

Nikodem Graczewski

Reporter

Joanna Bebak

Labels