Rework requisition domain and dto tests to use data builder pattern

Description

This ticket was created based on one of the incomplete 3.5 code freeze tasks.

Acceptance Criteria:

  • The tests in the requisition component should follow test data builder pattern

  • The changes should be committed in packages: domain, dto

Activity

Show:
Klaudia Pałkowska
May 17, 2019, 1:18 PM

The following parts of code need to be changed:

  1. RequisitionLineItemTest

  • all occurrences of new Requisition

  • all occurrences of new RequisitionLineItem

2. RequisitionTest

  • all occurrences of new RequisitionLineItem

  • all occurrences of new Requisition

  • line 1769 - new SupervisoryNodeDto

3. LineItemFieldsCalculatorTest

  • lines 129, 142, 421, 430 - new RequisitionLineItem

  • lines 342, 354, 385 - new RequisitionTemplate

  • line 351 - new AvailableRequisitionColumnOption

4. RequisitionTemlateColumnDataTest

  • line 117 - new AvailableRequisitionColumn

5. RequisitionTemplateColumnTest

  • lines 52, 55, 59, 60 - new AvailableRequisitionColumn

6. OrderLineItemDtoTest

  • line 31 - new OrderableDto

  • line 33 - OrderLineItemDto.newOrderLineItem

7. ProofOfDeliveryDtoTest

  • all occurrences of ProofOfDeliveryDto.builder()

8. ValidReasonDtoTest

  • line 32 - new ReasonDto

Paweł Cieszko
May 22, 2019, 11:57 AM

The missing data builders should have been added already.

Klaudia Pałkowska
May 23, 2019, 1:00 PM

Everything looks good now.

Assignee

Paweł Cieszko

Reporter

Paweł Cieszko

Labels

Story Points

3

Time tracking

24h

Sprint

None

Fix versions

Priority

Major
Configure