Rework requisition integration tests to use the data builder pattern

Description

This ticket was created based on one of the incomplete 3.5 code freeze tasks.

Acceptance Criteria:

  1. The tests in the requisition component should follow the data builder pattern

  2. The changes should be committed in the packages: integration test

Activity

Show:
Klaudia Pałkowska
May 17, 2019, 9:06 AM
Edited

I found the following places where we are not using builders:

  1. StatusChangeRepositoryIntegrationTest

  • line 63 - StatusChange.newSTatusChange

  • line 120

2. BaseRequisitionWebIntegrationTest

  • line 116 - BasicRequisitionTemplateDto.newInstance

3. BatchRequisitionControllerIntegrationTest

  • line 174 - ApproveRequisitionDto::new

4. RequisitionControllerIntegrationTest

  • line 2118 - new RightDto

  • line 2234 - new BasicRequisitionDto

Paweł Cieszko
May 22, 2019, 11:42 AM

The last object (BasicRequisitionDto) is used for exporting, so no data builder is needed there

Paweł Cieszko
May 22, 2019, 11:57 AM

The missing data builders should have been added already.

Klaudia Pałkowska
May 22, 2019, 2:31 PM

Now everything is fine.

Assignee

Paweł Cieszko

Reporter

Paweł Cieszko

Labels

Story Points

3

Time tracking

24h

Sprint

None

Fix versions

Priority

Major
Configure