Filter doesn't clear after clicking the Clear button


While checking AO-115, I noticed that the "Clear" button does not remove data from the filter.

Reproduction steps:

  1. Log into the application as a phsmanager2 and navigating to Stock Management > Receive.

  2. Click the "Make Receive" next to any program and add some product e.g. Linezolida.

  3. Type in keywords in the "Filter" modal and click the "Search" button e.g. Lin.

  4. Click the "Clear" button to remove product.

  5. Try adding another product e.g. Rifampicina

  6. The added product is not visible.

  • One can't see the products on the screen because the data from the last search has not been removed from the filter.

Expected results:

  • After clicking "Clear" all data on the screen should disappear.




Ben Leibert
May 18, 2020, 6:30 PM

This is definitely a good observation. Although it’s definitely reasonable to retain a preexisting filter as users add products, the fact that the “Clear” button doesn’t remove filtered products despite its modal’s warning that it will “remove all products and quantities” is clearly misleading. Rather than update the “Clear” button’s behavior, though, this could potentially be remediated by refining the modal’s message.

Step 16 of regression test says that use of the confirmation modal’s “Clear” button should cause “all products to disappear from the table.” Because it requires the entries to “disappear” rather than to be “removed” from the table, it seems that the current behavior needn’t keep the test from passing.

Because SIGLOFA’s behavior parallels that within Core OpenLMIS, I suggest that we move this ticket to the Core’s backlog for review and remediation.

Joanna Szymańska
May 19, 2020, 4:35 AM

Thank you for this comment. I agree that we can treat this issue as a task for improvement. I will move it to Core, because it needs to be fixed there, or just like you say, enter a better message for the user. Thus, I mark this test case as "Pass".




Joanna Szymańska