Proof of Delivery report can't be generated more than 10 times in a row

Description

After generating the Proof of Delivery report more than 10 times, the user gets HikariPool SQLTransientConnectionException:

Moreover the user cannot later enter the View Proof of Delivery screen. After clicking on the Manage button, the following error appears:

The issue was fixed in the Report service but we need to verify reports from other services as well.

Expected result:

  • It is possible to generate more than 10 reports in a row

  • It is possible to manage the Proof of Delivery

  • All the remaining reports from other services should be verified and fixed

Environment

None

Activity

Show:
Joanna Szymańska
December 16, 2020, 11:12 AM

Tested with success:

  • There were no problems generating more than 10 reports.

  • I was still able to manage the Proof of Delivery.

  • Stock reports were also generating.

Sebastian Brudziński
December 15, 2020, 2:40 PM

please update and check off the relevant item on the DoD

Paulina Buzderewicz
December 15, 2020, 2:29 PM
Edited

After adjusting code improvements according to the review, the following commits/files are ready to be reviewed again:

Fulfillment:

Stock Management:

Sebastian Brudziński
December 15, 2020, 2:21 PM
Edited

Note: Sonar complains about too small coverage for the added code (50% out of required 70%) but this is rather an issue with Jacoco not working well enough with try-with-resources statement -

https://stackoverflow.com/questions/17354150/8-branches-for-try-with-resources-jacoco-coverage-possible

Sebastian Brudziński
December 14, 2020, 3:16 PM

Thanks I left some comments on the commits inline

Done

Assignee

Paulina Buzderewicz

Reporter

Paulina Buzderewicz