Done issues

Add volume and temperature info to Orderables
OLMIS-6726
Previously entered values ​​appear in the Kit Unpack list
OLMIS-6248
Update Spring Boot to the latest 1.X version for Auth
OLMIS-6716
Mind The Parrot Sprint 141 meetings & backlog grooming
OLMIS-6723
Service Account tokens are expiring
OLMIS-6317
Performance improvements - 2019 retrospective
OLMIS-6725
It is possible to make Stock on Hand a negative number
OLMIS-6590
The call to permission strings is made twice upon login
OLMIS-6696
TradeItems Cannot Share LotCodes
OLMIS-6676
Error occurs when Unpack with "Unpacked From Kit" is submitted
OLMIS-6201
Physical Inventory UI: Pagination Support is Broken
OLMIS-6724
Slow page load on Physical Inventory page
OLMIS-6722
Investigate what consumes the most disk space on Jenkins
OLMIS-6715
There are two requests for Supervisory Nodes when user is logging in
OLMIS-6698
Add ability to load organizations by refdata-seed tool
OLMIS-6515
Allow updating orderables in OpenLMIS Configuration tool
OLMIS-6455
Mind The Parrot Sprint 140 meetings & backlog grooming
OLMIS-6717
Incorrectly divided table on the Supply Lines screen
OLMIS-6150
Some screens break after changing the language several times in a row
OLMIS-6138
Error occurs when adding products for EM in Stock Management > Issue
OLMIS-6134
It's impossible to assign a requisition group to a different supervisory node
OLMIS-6109
Can't approve a demo data split requisition
OLMIS-6091
Duplicated line item on the Pick Pack List
OLMIS-5957
It's possible to create a user after clicking Cancel
OLMIS-5948
Can't split requisition when two supply partners have the same association but other products
OLMIS-5924
The Maximum stock quantity column is not visible in print
OLMIS-5884
Products on the Products page are not displayed in the correct order
OLMIS-5875
Popovers and selects not displayed correctly on two Admin screens in smaller resolutions
OLMIS-5804
Performance test metrics for processing period endpoints
OLMIS-3634
Plug-Ins Effect on Physical Inventory
OLMIS-5665
The JSON concerning the Southern Region geographic zone causes the API Console to freeze
OLMIS-5613
Add Reasons button is misaligned one the Physical Inventory screen
OLMIS-4533
Can't make an adjustment as srmanager1
OLMIS-4428
Space shows up when resizing openlmis-table-pane in firefox
OLMIS-3621
CLONE - Receive: Performing an ad hoc receipt
OLMIS-6570
User with home facility role with no home facility still sees Requisitions tab
OLMIS-6226
User can navigate to screens they are not authorized to view
OLMIS-6592
Release 3.8
OLMIS-6713
Mind The Parrot Sprint 139 meetings & backlog grooming
OLMIS-6702
The data on the first page of the requisition are frequently lost after going to the second page
OLMIS-6684
Fetch FTAPs only for full-supply products in requisition V2 update
OLMIS-6707
3.8 RC2 Performance testing
OLMIS-6709
For rejected requisition, print shows approved quantity
OLMIS-2838
3.8 RC2 Regression testing: Test cases
OLMIS-6710
Release 3.8 RC2
OLMIS-6712
3.8 RC1 Regression testing: Exploratory testing
OLMIS-6695
Investigate performance improvements for FTAPs on UI
OLMIS-6708
3.8 RC1 Regression testing: Performance testing
OLMIS-6694
3.8 RC1 Regression testing: Test cases
OLMIS-6693
E-Mail and SMS notifications: verify the proper functioning and update documentation if needed
OLMIS-6601
issue 1 of 4764

Add volume and temperature info to Orderables

Description

According to notes gathered on Volume and Temperature support page and SELV3-13, we need to introduce a couple of fields to Orderable class in Referencedata service.

Acceptance Criteria:

  • orderable model should be changed according to the following diagram:

  • this model needs some changes:

  1. BaseMeasurement and Measurement classes should be abstract

  2. BaseMeasurement class should have an abstract method getCodeListVersion declared

  3. there should be a new class that extends Measurement class - VolumeMeasurement

  4. inBoxCubeDimension field should be VolumeMeasurement type

  5. there should be 2 enum classes: TemperatureUnitCode and VolumeUnitCode, both should contain single code - CEL (https://www.gs1.org/docs/gdsn/mjr3_comm_announcement_october/UoM_Data_Migration.xlsx) for temperature and MLT (https://asiakas.gs1.fi/en/content/view/full/29917) for volume

  6. VolumeMeasurement and TemperatureMeasurement classes should have implemented method getCodeListVersion that returns all available codes from related enums

  • changes should include new migration for the Referencedata service database

  • 2 parameters should be added to GET /api/facilities/{facilityId}/approvedProducts - minimumToleranceTemperatureGreaterEqualThan and maximumToleranceTemperatureLessEqualThan - this could be dropped if we decide that all products should be available on the UI in requisition object (this should avoid fetching orderable again and would require fewer changes but more would be done on the UI)

  • please add basic validations for those fields (volume above 0, max temp bigger than min temp etc.)

  • all the changes should be submitted as pull requests

  • changes on the UI made in SELV3-13 now need to point to new fields added in this ticket and be moved to the core project

  • Chongsun or Josh needs to be added to the pull requests as reviewers

 

Status

Assignee

Aleksandra Sołtys

Reporter

Aleksandra Sołtys

Time tracking

40h

Components

Fix versions

Priority

Major
Configure