Page Comparison

...

• Convert to order should be a fulfillment right. It is by warehouse, not by program. 
• Need an integration test for FacilityFtpSettingRepository.findFirstByFacilityId (done: test)
• Order domain object should not use Json annotations, but DTO for serial/deserial
• Remove all hardcoded English strings that get returned to the client 

  Jira Legacy
  server JIRA (openlmis.atlassian.net) columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 448ba138-230b-3f91-a83e-16e7db1deed1 key OLMIS-1399

• Remove extra headers (X-Content-Type-Options, X-XSS-Protection) in RAML (done: review)
• All endpoints should have controller integration tests for different HTTP codes; add JSON schemas (generally a regular JSON for 2XX codes, and errorResponse for 4XX codes) 

  Jira Legacy
  server JIRA (openlmis.atlassian.net) columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 448ba138-230b-3f91-a83e-16e7db1deed1 key OLMIS-1499

• Remove 500 errors from RAML (any endpoint can return it, but we do not have integration tests for these cases)
• Change errorResponse.json to have message and messageKey, not message and description 

  Jira Legacy
  server JIRA (openlmis.atlassian.net) columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 448ba138-230b-3f91-a83e-16e7db1deed1 key OLMIS-1399

• Error handling classes should not log error, but should log debug (these are not actually errors)
• Order.status should not be settable from a DTO.
• Need to redesign to remove Dtos from Order domain object.
• Doesn't make sense for StatusMessage object to be part of Order object. Doesn't seem to be used anywhere and if it's needed, it should be retrieved from the Requisition service.
• Doesn't make sense for StatusChange object to be part of Order object. Only thing that appears to need it is the order report, and that could be filled in the DTO. It should be retrieved from the Requisition service.
• It's unclear what facilityId is used for and why it's necessary, since there is requestingFacilityId, supplyingFacilityId and receivingFacilityId.
• Move all authentication stuff in OrderController and ProofOfDeliveryController to PermissionService.
• OrderController.getAllOrders should be paginated, if we need it. We may not want to have it, and just have everyone use the order search endpoint.
• ExporterBuilder seems strange, as every time you need to convert something to DTO, you have to add another method to it.
• Update README (stale)

Notification Service

...