Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

ProblemSolutionTickets
Inconsistent HTML markup makes it harder for implementers to change large style applications across the OpenLMIS-UI.

Inconsistencies need to be identified and action needs to be taken to:

  • Create and document a pattern
  • Clean up code that doesn't fit this pattern

Jira Legacy
serverJIRA (openlmis.atlassian.net)
serverId448ba138-230b-3f91-a83e-16e7db1deed1
keyOLMIS-2936

Modals look gross, and there are variations in how and when modals are used.
  • Jira Legacy
    serverJIRA (openlmis.atlassian.net)
    serverId448ba138-230b-3f91-a83e-16e7db1deed1
    keyOLMIS-2592
  • Jira Legacy
    serverJIRA (openlmis.atlassian.net)
    serverId448ba138-230b-3f91-a83e-16e7db1deed1
    keyOLMIS-2443


Program/Facility filter/select is implemented and used different sections of the OpenLMIS-UI
  • Jira Legacy
    serverJIRA (openlmis.atlassian.net)
    serverId448ba138-230b-3f91-a83e-16e7db1deed1
    keyOLMIS-2955
  • Jira Legacy
    serverJIRA (openlmis.atlassian.net)
    serverId448ba138-230b-3f91-a83e-16e7db1deed1
    keyOLMIS-2424
Directions for searching on list pages is not always clear
  • Jira Legacy
    serverJIRA (openlmis.atlassian.net)
    serverId448ba138-230b-3f91-a83e-16e7db1deed1
    keyOLMIS-2447
  • Jira Legacy
    serverJIRA (openlmis.atlassian.net)
    serverId448ba138-230b-3f91-a83e-16e7db1deed1
    keyOLMIS-2656
  • Jira Legacy
    serverJIRA (openlmis.atlassian.net)
    serverId448ba138-230b-3f91-a83e-16e7db1deed1
    keyOLMIS-2727

It is too easy to click off the modal in the add screen of stock management and loose all the work the user has done



Unit Tests

  • Testing a directive is tricky
  • UI-Routes could use some tests


sticky-columns can't be "easily used"


CSS restyling:

  • Comments status message
  • openlmis-table borders



Jira Legacy
serverJIRA (openlmis.atlassian.net)
serverId448ba138-230b-3f91-a83e-16e7db1deed1
keyOLMIS-2821

As the OpenLMIS-UI evolves, we need to make sure the code base is stable
  • Sonar unit test coverage
  • Sonar module dependency tracking
Jira Legacy
serverJIRA (openlmis.atlassian.net)
serverId448ba138-230b-3f91-a83e-16e7db1deed1
keyOLMIS-3195
Date Picker implementation is screwy
  • Jira Legacy
    serverJIRA (openlmis.atlassian.net)
    serverId448ba138-230b-3f91-a83e-16e7db1deed1
    keyOLMIS-3010
Year selection component – we don't want to rewrite year formatting guidelines....
Jira Legacy
serverJIRA (openlmis.atlassian.net)
serverId448ba138-230b-3f91-a83e-16e7db1deed1
keyOLMIS-3043
Alert warning is only used once
Jira Legacy
serverJIRA (openlmis.atlassian.net)
serverId448ba138-230b-3f91-a83e-16e7db1deed1
keyOLMIS-3080


Jira Legacy
serverJIRA (openlmis.atlassian.net)
serverId448ba138-230b-3f91-a83e-16e7db1deed1
keyOLMIS-3081

...

http://docs.openlmis.org/en/latest/conventions/uiCodeConventions.html#unit-testing-guidelines