...
Problem | Solution | Tickets | ||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Inconsistent HTML markup makes it harder for implementers to change large style applications across the OpenLMIS-UI. | Inconsistencies need to be identified and action needs to be taken to:
|
| ||||||||||||||||||||||||
Modals look gross, and there are variations in how and when modals are used. |
| |||||||||||||||||||||||||
Program/Facility filter/select is implemented and used different sections of the OpenLMIS-UI |
| |||||||||||||||||||||||||
Directions for searching on list pages is not always clear |
| |||||||||||||||||||||||||
It is too easy to click off the modal in the add screen of stock management and loose all the work the user has done | ||||||||||||||||||||||||||
Unit Tests
| ||||||||||||||||||||||||||
sticky-columns can't be "easily used" | ||||||||||||||||||||||||||
CSS restyling:
| ||||||||||||||||||||||||||
| ||||||||||||||||||||||||||
As the OpenLMIS-UI evolves, we need to make sure the code base is stable |
|
| ||||||||||||||||||||||||
Date Picker implementation is screwy |
| |||||||||||||||||||||||||
Year selection component – we don't want to rewrite year formatting guidelines.... |
| |||||||||||||||||||||||||
Alert warning is only used once |
| |||||||||||||||||||||||||
|
...
http://docs.openlmis.org/en/latest/conventions/uiCodeConventions.html#unit-testing-guidelines
Examples | ||
---|---|---|
Brittle | Checks markup, not meaning | |
Set up view that is available in router? | https://github.com/OpenLMIS/openlmis-cce-ui/blob/master/src/cce-edit-inventory-item/edit-inventory-item.html.spec.js#L655-L672 | |
Testing utils bundled into applicaiton? | https://github.com/OpenLMIS/openlmis-cce-ui/blob/master/src/openlmis-testing-utils/openlmis-testing-utils.module.js |