...
- You've received a request for a review, open the review - participating in code reviews helps us all improve
- If you're unable to complete this review before the due date has passed, please inform the review author so they may re-assign it. If you feel strongly that someone else would be a better fit, suggest that to the author. Try not to leave a review half-way through, commit to it till it's closed.
- Review the change, following the Code Review Checklist.
- Provide constructive feedback if warranted or simply acknowledge that the code looks OK. If you have concerns, be specific and reference the components in the review checklist, mark the concern as a defect. You can use the "Needs Resolution" feature to mark comments as requiring to be resolved.
- Make sure that whenever already existing logic is modified a new test is added that checks the specific change that has been implemented (along with updates to already existing tests, if they were needed).
- Complete the review. If you left feedback, be ready for review author's response to them.
- Participate in the review until all problems are resolved (bear in mind to complete review every time you finish providing feedback). If you marked issues as needing resolution and they were resolved, then mark them as so.
- To inform review author that it may be closed, acknowledge that the code looks OK and complete the review.
...