Page Comparison

...

• Lot Codes were implemented (OLMIS-2262) with a validator that requires global uniqueness. That logic is probably incorrect. 

  • In LotValidator.java verifyCode() method, it forces each lot to be globally unique. I believe correct behavior is that LotCodes are only unique within a given Trade Items. Definitely two different TradeItems might both have a Lot Code "100", for example. OR perhaps we should have no constraints around uniqueness at all.

• /users/userId/fulfillmentFacilities needs rightId parameter (similar to /users/userId/supervisedFacilities)
• SupplyLine search has search and searchByUUID, which seems like it should be consolidated to one search endpoint.
• Remove all hardcoded English strings that get returned to the client
• Remove extra headers (X-Content-Type-Options, X-XSS-Protection) in RAML
• All endpoints should have controller integration tests for different HTTP codes; add JSON schemas (generally a regular JSON for 2XX codes, and errorResponse for 4XX codes)
• Remove 500 errors from RAML (any endpoint can return it, but we do not have integration tests for these cases)
• Change errorResponse.json to have message and messageKey, not message and description
• Error handling classes should not log error, but should log debug (these are not actually errors)
• Update README (stale)

UI

• Extra file structure in src
• Legacy code preventing minification
• Some 'new' code doesn't use angular injection with strings — so it will no minify
• Translation file is gigantic and we don't use most of the strings — needs to get cleaned or made into simpler file
• Grunt build tasks in huge file and hard to understand/read/work with
• Missing unit tests and documentation in odd number of files
• CSS is getting re-written in different modules (hopefully styleguide will help with this)

Platform

Below are platform-level issues. They may impact multiple services or impact the build and tooling. Many of these items were formerly in the "Dev and Build Infrastructure" epic (OLMIS-584); much of that epic was moved into label=TechBacklog, component=Platform, and fixVersion was erased so we could re-prioritize what of these issues are a priority.

...