| Table of Contents |
|---|
All services
- Standardize utility classes into the util package, NOT utils.
- Turn on disabled tests.
- Audit to make sure all relevant unit tests/automated tests from v2 are covered in v3.
- Add more thorough logging. (A quick review of the reference-data and requisition services suggest that controllers sometimes perform CRUD operations without logging anything.)
- Showing a service's version creates a new Java object. Seems like it should just be a static method, since version info doesn't change over the life of the application.
...
- Lot Codes were implemented (OLMIS-2262) with a validator that requires global uniqueness. That logic is probably incorrect.
In LotValidator.java verifyCode() method, it forces each lot to be globally unique. I believe correct behavior is that LotCodes are only unique within a given Trade Items. Definitely two different TradeItems might both have a Lot Code "100", for example. OR perhaps we should have no constraints around uniqueness at all.
- /users/userId/fulfillmentFacilities needs rightId parameter (similar to /users/userId/supervisedFacilities)
- SupplyLine search has search and searchByUUID, which seems like it should be consolidated to one search endpoint.
- Remove all hardcoded English strings that get returned to the client
- Remove extra headers (X-Content-Type-Options, X-XSS-Protection) in RAML
- All endpoints should have controller integration tests for different HTTP codes; add JSON schemas (generally a regular JSON for 2XX codes, and errorResponse for 4XX codes)
- Remove 500 errors from RAML (any endpoint can return it, but we do not have integration tests for these cases)
- Change errorResponse.json to have message and messageKey, not message and description
- Error handling classes should not log error, but should log debug (these are not actually errors)
- Update README (stale)
UI
...
Ready For Work
| Jira Legacy | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|
|
...