...
- Only HTML changed
Search file might be too big – ideally only table would be changed
Should PR to Core
| Solution |
|---|
- Needs unit tests
- Needs documentation
- Could be used to fix print url hacks in other places – should be addressed separately
| | Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-435 |
|---|
|
|
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-169 |
|---|
|
- This should be brought over to CORE
- Unit tests are needed
| | Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-436 |
|---|
|
|
Should be Moved
All the changes for the MW-UI were made directly in that repository, which means git can't merge changes. Fixing this would mean forking the original repository, and creating an image from that forked repository that is used in the MW-UI.
The benefit is this would allow git to automatically merge most code changes. As the core product releases new versions over time, git upstream code can be pulled into MW-UI while preserving the local modifications. This greatly reduces ongoing maintenance effort of conducting each upgrade.
...
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-84 |
|---|
|
- There are plans to merge these feature changes back to core – getting this code out of MW-UI and into a place where make a PR would be trivial makes sense
- Fork OpenLMIS/openlmis-requisition-ui to OpenLMIS-Malawi/openlmis-requisition-ui
- Having a correct fork would make maintenance and merging changes easier
| | Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-454 |
|---|
|
|
- There are a handful of changes here, that either should
|
...
- be refactored to smaller changes instead of forking a file
- Until that happens, the changes should live in OpenLMIS-Malawi/openlmis-requisition-ui
|
|
Needs Improvement
...
- is tightly coupled to other "start up" actions,
|
...
- should be refactored to use an extension mechanism
- Either an event OR $q.all w/$filter
| | Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-437 |
|---|
|
|
TB Quarterly Warning| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-81 |
|---|
|
|
...
...
- to add an alert - this can be accomplished by decorating the controller method
| | Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-438 |
|---|
|
|
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-217 |
|---|
|
|
...
- in add-product-modal.html - this can be done in a reusable/testable way by:
- add decorator to controller
- sort products in factory
| | Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-439 |
|---|
|
|
Full Forks to Change a Link- To change a link, we are:
- Forking the controller file, and adding two new methods
- Forking the HTML to change the link
- This can be done more cleanly by
- decorating the controller to change the link (no need to touch the HTML)
- refactoring the controller to use a factory to produce the link
- refactor to use external-url method (mentioned above)
- Target directories
| | Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-434 |
|---|
|
|
Uncertain
| Solution |
|---|
Requisition Initiate| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-237 |
|---|
|
File - Most of the changes to this file have been to maintain warning message
- CORE won't follow this design direction
|
|
- Seems to be added to fix other
|
...
- bugs – Seems like it could be removed entirely
|
...
- Could you look into if we
|
...
...
- Looks like many of the changes are to support the report-url changing
- This could be done without forking, probably
- Git history here doesn't have many ticket numbers, so its hard to figure out WHY changes were made
Tickets created by Weronika Ciecierska (Unlicensed) as a result of discussion with Nick Reid (Deactivated):
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-437 |
|---|
|
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-434 |
|---|
|
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW |
|---|
|
|
...
...
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-440 |
|---|
|
...
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-438 |
|---|
|
...
| Jira Legacy |
|---|
| server | JIRA (openlmis.atlassian.net) |
|---|
| columns | key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution |
|---|
| serverId | 448ba138-230b-3f91-a83e-16e7db1deed1 |
|---|
| key | MW-439 |
|---|
|
...
|
- Looks like many of the changes are to support the report-url changing
- This could be done without forking, probably
- Git history here doesn't have many ticket numbers, so its hard to figure out WHY changes were made
|
|