Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

DRAFT

Overview

This document has been created to show poor performance of requisition submit/save endpoints. It contains:

...

  • Lines 87-95: Fetch each of requisition's non full supply products from reference data service one by one.

Solutions

Both save and submit:

  • Return only relevant information about a requisition to the client: Do we really need to return non full supply products in the response of those endpointendpoints? Perhaps we could keep this as a set of UUIDs instead of calling orderableReferenceDataService.findOne for each one of them, or, if really needed, create a batch endpoint that returns all of them at once

Submit:

  • We could reuse products that were previously retrieved in RequisitionController. 
  • Try not to fetch all the orderables, search them by facility/program instead.