...
Convert to order should be a fulfillment right. It is by warehouse, not by program.Need an integration test for FacilityFtpSettingRepository.findFirstByFacilityId(done: test)Order domain object should not use Json annotations, but DTO for serial/deserialRemove all hardcoded English strings that get returned to the clientJira Legacy server JIRA (openlmis.atlassian.net) columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 448ba138-230b-3f91-a83e-16e7db1deed1 key OLMIS-1399 Remove extra headers (X-Content-Type-Options, X-XSS-Protection) in RAML(done: review)All endpoints should have controller integration tests for different HTTP codes; add JSON schemas (generally a regular JSON for 2XX codes, and errorResponse for 4XX codes)Jira Legacy server JIRA (openlmis.atlassian.net) columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 448ba138-230b-3f91-a83e-16e7db1deed1 key OLMIS-1499 Remove 500 errors from RAML (any endpoint can return it, but we do not have integration tests for these cases)Change errorResponse.json to have message and messageKey, not message and descriptionJira Legacy server JIRA (openlmis.atlassian.net) columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution serverId 448ba138-230b-3f91-a83e-16e7db1deed1 key OLMIS-1399 Error handling classes should not log error, but should log debug (these are not actually errors)- Order.status should not be settable from a DTO.
- Need to redesign to remove Dtos from Order domain object.
- Update README (stale)
Notification Service
...