Versions Compared

Key

  • This line was added.
  • This line was removed.
  • Formatting was changed.

...

TimeItemWhoNotes
5min
  • UAT by Serge & JSI
    • Discuss testing progress in Sprint 34
      • If any help is needed for QA please post in the QA slack channel
Sam
20min 
  • Unit test discussion
    • SonarQube stats don't show integration tests 
    • Unit tests coverage for the domain are only 16% 
      • The goal of a domain is to be well encapsulated - has no dependencies on other infrastructure/plumbing, the domain is about business functionality.
    • Next steps:
      • Some of the notification logic should be moved into the domain. 
      • Unit test coverage should be higher in the domain.
      • Csvparser and reader should include unit tests.
      • What is the UI unit test coverage currently? Sam will schedule a follow up discussion for this.
    • How do we catch this earlier? So that the unit tests are associated with the portion of code where they belong? 
      • This doesn't exist yet. We have not been doing domain-driven design.
      • The first step would be setting a pattern for people to use, and then demonstrate it to them.
      • We could refactor CCE to show this pattern. Nikodem Graczewski (Unlicensed) will create a ticket for this.
 
5min
  • Bug/defect triage reviews. We should start reviewing bugs logged and triage them in this meeting.
Sam

Action items