We didn't get to this, we'll save it for June 13th call
Notes
FTAP
Currently has no update ability
FTAP is by facility type, program, orderable (/product)
Update doesn't make much sense
deleting would make more sense / potentially archiving
for archiving we'd need to figure out if another service (e.g. Requisition) needs to know about a historical/original FTAP
Requisition service likely could tolerate a delete operation
don't know about Fullfillment and Stock Management
Requisition that is initiated would not want to change if the FTAP changed
No search endpoint (to get all)
POST /ftap/search
program
facility type
Email Templates
Desire to incl geo zones in Requisition status change emails
Currently placeholders are limited and hardcoded (status, program, etc)
Could we pass in a more complex object and traverse it (e.g. using dot notation)?
We're not sure if it'd work "out of the box"
If it did we think it'd be enough to pass the Requisition object
Next steps: check if it works "out of the box", if not just add a few more fields (expect MW team PR)
System Settings
Currently in DB (Requisition service?). No endpoints to modify them
Fullfillment uses these settings, and also store email templates in these settings
email templates moved over to transifex
Req
timezone and fromEmail (this is already moved to .env)
We should delete all of these settings endpoints (Req and Fullfillment)
For Malawi, if they need to change an email template, they'd create a Transifex project for the country/impl (e.g. en_MW) and change it... Any changes to this need to wait until the next release of the Service. Malawi team thinks this is acceptable.
Language list comes from Transifex
System could have a default language that all users default to.
Currently Malawi is using the UI extension technique to change translations, instead of Transifex.
suggestion is to use Transifex
Currently:
might use cookie on back-end, not sure if UI uses that cookie
default if no cookie is to use english
Quick next:
make the default system language part of the .env file
Ideal Next:
User has a profile with a language setting
System has a default language that's used for a user that doesn't have a profile yet or for a new user's profile
For Malawi this ideal next is a low priority, IF the Quick Next is done.
Sebastian Brudziński and Josh Zamor to research FTAP update as delete OR archive - what would Stock Management and Fulfillment service do if FTAP is removed or changed? What should be the general strategy for Reference Data Service for update / delete operations.
Sebastian Brudziński & team to issue PR to Requisition service for new email template fields (and possibly new technique to pass complex objects and navigate them within the template)?
Paweł Albecki (Deactivated) to write ticket to remove the now defunct system settings api(s) of Fulfillment and Requisition -
Ben Leibert to followup with Nick Reid (Deactivated) on Malawi's UI approach in translations. Malawi is using the UI "override" extension technique to change translations, as well as for new screens developed. Josh Zamor doesn't think this would be recommended. Ben Leibert would write tickets for changing this in the MW project if we're all in agreement.
Paweł Gesek to write ticket for a default language setting that's set via the system environment (i.e. the .env file) -
Josh Zamor and Ben Leibert to provide wiki page on Transifex limits: projects, strings, users, groups. Goal is to ensure that community can continue to rely on Transifex's open source donation, even for implementation projects
Josh Zamor to write "ideal next" ticket for language settings