Watch learning material Clean Code: Writing Code for Humans
Discussion
Could we cut names from *ReferenceDataService to *Gateway?
Our $onInit methods on UI are not descriptive and logic should be moved to factories.
We should avoid excessive indentations - reporting code smells. Probably maximum number should be decreased on Sonar.
Why build pass despite the fact that requisition constructor takes 8 params? Are we using checkstyle properly?
Wrap up
We have asked every participant to give a score on how useful this meeting was and how helpful this specific material was. The voting was anonymous and each participant could give a score from 1 (useless) to 10 (very useful).
Average how useful was this specific material: 6.0
Action items
Mateusz Kwiatkowski to continue conversation about restricting Sonar Quality Gate