View Source

Date

06 Mar 2018

7am PST / 4pm CET

Meeting Link

Note we're using Zoom now:

Join from PC, Mac, Linux, iOS or Android: https://zoom.us/j/737202874

Or iPhone one-tap :
US: +16699006833,,737202874# or +14086380968,,737202874#
Or Telephone:
Dial(for higher quality, dial a number based on your current location):
US: +1 669 900 6833 or +1 408 638 0968 or +1 646 876 9923
Meeting ID: 737 202 874
International numbers available: https://zoom.us/zoomconference?m=F0kj5u6u0wFxr7Xfz5NKZxl0xyLhuTPF

Attendees

Goals

See discussion items

Discussion items

Time	Item	Who	Notes
10m	Agenda and action item review	Josh Zamor	Open Action item review from https://openlmis.atlassian.net/wiki/x/vAAND Open action items from last time: Chongsun Ahn (Unlicensed) to add docs on http caching / dtos Paweł Albecki (Deactivated): take the feedback from the DDD and package name improvements and show through a diagram and/or use of the example service what it'd look like given that feedback Josh Zamor: to respond to comment on wiki page To the group: bring up what you'd like to see as part of the technical mobile strategy in the dev forum (Product Committee may look at some of this feedback) Chongsun Ahn (Unlicensed) to post dev forum post and point devs how to update intellij (we have documentation on this) on import order, google styleguide, etc
	Dates and times	Chongsun Ahn (Unlicensed)
	Sonar Quality Gate	Mateusz Kwiatkowski	Pipeline? Stopping deployments?
	Too freq deploys to performance server	Sebastian Brudziński	Review - daily or code commit

Notes

Dates and Times

In reference:

When following up with UI timezone, it appears that the browser's timezone is used, we'd likely prefer the user's profile timezone - don't have that yet so we have a "system timezone" - application timezone?

TIME_ZONE_ID - Application as in what time zone to use for processing periods...

Used in jasper reports for display to the user
user enters a date-time, we check using the TIME_ZONE_ID?
If Req gets a period from Reference Data, it presumes that timezone is this TIME_ZONE_ID

API to give to UI?

The UI doesn't have a way to learn of a user's or facilities timezone

Use in UI components?

Mostly it's dates except for stock management sends time
timezone is stripped from iso dates applies / converts to UTCISO8601 in UTC is sent to the serverDate's are sent to the server
- UI created a date-time (for a day)time and time-zone was stripped (it was converted to UTC)
  - Before(UTC -5): 2018/02/28 → 2018-02-27T19:00:00Z → 2018-02-27
  - Now (UTC -5): 2018/02/28 → 2018-02-27T19:00:00Z → 2018-02-28T00:00:00Z → 2018-02-28
- For the isoDateFilter (used by DatePicker)

Next step:

Writes tickets for guidance doc - RTD and UI styleguide (ISODateFilter and DatePicker), and product roadmap features:
- User profile timezone
- Facility timezone / application timezone

Sonar Quality Gate

Proposal: fail the quality gate if the code introduced any code smell

because we didn't fail the job/deployment
instead we'll notify Slack

Will help reviewer's as they won't need to check sonar itself - they can check Slack

Badges - no one cares for these

Perf Tests

Next steps:

convert to daily builds
for failing builds

Action Items

Josh Zamor to write those tickets
Nikodem Graczewski (Unlicensed) to write UI styleguide tickets
Mateusz Kwiatkowski: to write ticket for sonar quality gate to fail on any code smell - and notify slack
Sebastian Brudziński to write ticket to convert to daily builds - perf tests -
Josh Zamor - perf builds are red...