2017-02-07 Meeting notes

Date

07 Feb 2017

7am PST

Meeting Link

https://www.uberconference.com/villagereach-isg

Optional dial in:
Dial in: 213-493-0531
PIN: 74762

Attendees

• Josh Zamor

• Elias Muluneh

• Nick Reid (Deactivated)
• Ben Leibert
• Brandon Bowersox-Johnson
• Pengfei Cui (Deactivated)
• Paweł Gesek
• Sebastian Brudziński
• Nikodem Graczewski (Unlicensed)

Goals

• This meeting might be a bit light this week, we've been busy covering the bases for 3.0
• Possible topics from dev forum:
  • API versioning
  • pagination
  • loading demo data
  • code-review tools

Discussion items

Notes

Demo Data

https://groups.google.com/forum/#!topic/openlmis-dev/kHr8f6oqpd4

Currently loading from JSON to SQL into DB schema.  Plan to change to API.

Problem: 

• demo data becomes invalid (referential integrity cross service not enforced until runtime). 
• UUID's not human friendly to read either.
• Time sink.
• giving control to the end demo magician?
• many of the issues lie at the service boundaries (inter-service)

Brainstorming:

• visual tool to see linkages (ERD tool for couchdb)
• multiple comments (short term solution) to have a human readable desc of foreign UUID - problem of changes to doc / uuid getting out of sync
• v2 codes (more human readable) - had to upload in certain order, a lot of different code spaces (product categories had a code) - short synopsis is moving from a 20 character code to a 5 character code
• Put it all into one big excel sheet (workbook or one sheet? tbd) and a number of loading scripts.  Next level (1000) is a customized service - a hat with a css animation? 
  
  • Would be nice to not have internet dependency.
  • Lots of (duplicated) work for validation in excel that the server would also have
  • Calculations cross-domain are complicated!
  • Excel might be for reference data,  rest of demo-data might be through DB snapshots
• dev forum centered around a service validating it's data - it would check external service FK

Todo next:

• make a ticket as a feature for end-user requirements to socialize for the ideal solution (Nick Reid (Deactivated))
• malawi implementation will have to do this if we don't - they'd inform us

Delete endpoints

https://groups.google.com/forum/#!topic/openlmis-dev/cFAKXkd_QwA

Problem:

• Deletes were resulting in constraint violations (so HTTP 500).
• What to tell SM - should they be resilient?

Notes:

• Current solution is to go ahead and use the DELETE endpoints (refactored) in fulfillment and requisition services, recommend against using DELETE endpoints/operations of ref data service.
• Should DELETE occur?
  • DELETE to archive - mark as this
    
    • unique name constraint check would have to ignore archived things
  • DELETE to actually delete (no more UUID)
    • created by mistake

Next Steps

• an example of archiving of commodities (Josh Zamor)
• business side to DELETE a facility, commodity, etc (Paweł Gesek)

Action items