2017-12-12 Meeting notes
Date
Dec 12, 2017
7am PST / 4pm CET
Meeting Link
Toll: +1-415-655-0001
Number: 199 948 686
Attendees
All are welcome
@Josh Zamor (Deactivated)
@Paweł Albecki (Deactivated)
@Łukasz Lewczyński (Deactivated)
@Mateusz Kwiatkowski
@Brandon Bowersox-Johnson
@Elias Muluneh
@Nikodem Graczewski (Unlicensed)
@Sebastian Brudziński
@Mary Jo Kochendorfer (Deactivated)
@Chongsun Ahn (Unlicensed)
Goals
Identify all the discussions occurring on the dev forum - is it still in discussion? Does it have tickets? Need prioritizing? Already in progress? Done?
Dive deep on expanded rest pattern
Discussion items
Time | Item | Who | Notes |
|---|---|---|---|
20m | Action Item review from last time | @Josh Zamor (Deactivated) | Where are these discussions?
|
20m | expanded REST pattern | @Sebastian Brudziński | Where is it? How do I follow it? |
| if time: Equals and hashcode in Java (and DTOs) | @Chongsun Ahn (Unlicensed) |
|
Notes
Orderable edit
going with versioning
tickets: https://openlmis.atlassian.net/browse/OLMIS-3804
Investigate and design pattern for versioned endpoints (ticket)
Implement versioning in orderables - write operation (ticket)
Go through parts of code for things which are immutable
update classes that use them (Requisition, ) and the REST json with a version # in it that references Orderables
propose a cool down period (days to week)
to think about other places in the code that need changes
Orderables and program Oderables for Malawi before FTAP
REST issues
Multiple errors in REST
Agreed to nested fields instead of flattened fields.
Next steps:
change our APIs and Validators (Req and Ref data) to use these
Skipping authorization
taking approach where submit step is going direct to AUTHORIZED status
with a button that says "Submit and Authorize" (or button that says "Authorize")
get rid of AUTHORIZED status - no technical reason to need both statuses (the state stays the same, we have an authorize and approval still). This isn't blocking previous action item.
If it's IN_APPROVAL state, at least one other entity has gone through and reviewed that RnR.
IN_APPROVAL status added for reporting
Expanded REST pattern
Step by step guide:
https://groups.google.com/forum/#!topic/openlmis-dev/lvpKa1Krgec
Action Items
see inline above