2018-10-30 TC Meeting notes
Date
Oct 30, 2018
7am PST / 4pm CET
Meeting Link
Attendees
@Josh Zamor (Deactivated)
@Sebastian Brudziński
@Mateusz Kwiatkowski
@Nikodem Graczewski (Unlicensed)
@Łukasz Lewczyński (Deactivated)
@Chongsun Ahn (Unlicensed)
@Elias Muluneh
@Mary Jo Kochendorfer (Deactivated)
@Wesley Brown
@Paulina Buzderewicz
@Klaudia Pałkowska (Deactivated)
(did I miss anyone?)
Discussion items
Time | Item | Who | Notes |
|---|---|---|---|
5m | Agenda and action item review | Josh |
|
15m | Followup on audit log initializer
| @Josh Zamor (Deactivated) |
|
10m | Orderable versioning | @Chongsun Ahn (Unlicensed) |
|
(for next time) | Data Pumps: Debezium | @Josh Zamor (Deactivated) |
|
(for next time) | DHIS2 followup on how (keeping this on the agenda to discuss the plan prior to implementation, however implementation isn't pressing on this just yet) | @Josh Zamor (Deactivated) |
|
Notes
Do we want to change time (DST)?
It sounds like not (if there is someone in a timezone where this becomes harder to attend because of daylight savings changes, please let us know and we'll try to accommodate)
Audit log initializer
Currently bogged down in CCE alerts under demo data (the developer workflow primarily)
Stock Mgmt screen was slower - not sure if this is from # of new orderables, or start up sequence of audit log initializer
Are we starting ref distro locally?
Some say yes
Only if changes in several services, otherwise push and see in test. Run ref distro to test demo data.
Run ref distro migration changes (working on Jenkins migration test problems) - running it locally.
In UI dev you don't need to run ref distro, the UI dev can work off a deployed cloud instance
Some / many aren't starting ref distro locally
Would be nice to catch build failures before they got pushed (and so would make sense if people weren't starting it locally)
Biggest problems:
time consuming to launch ref distro
configurations (after some months of not running, the changes to setup required debugging / migration)
Changing a single module (service?) - we don't have documentation to show how that's done.
Negative for marketing to new devs / users:
Native developer experience
e.g. IntelliJ idea running tests (would need to disable the login/auth, which might accidentally get committed, for integration tests)
Keep development instance more up to date so that we could build outside of docker (it's more efficient)
NodeJS issue with version 6 and version 9 - dev-ui is version 7, on mac only 6 and 9 are installable.
Complicated setup - settings.env and the profile that's used.
When services haven't all started on login, you'll get an error.
Big machine - Make services more efficient, explore service meshes (though would require big internet), etc
Orderable
Thread: https://forum.openlmis.org/t/orderable-edit-design/455/16
No longer extends base entity due to compound primary key
Foreign keys from other tables sometimes needs to also have a version indicator
Main lessons:
Our tools really don't like this: Hibernate and the ORM impedance mismatch
Composite keys are difficult, if we were to do this again, try to stay away from composite keys (there were a couple other potential solutions but couldn't get those to work)