Done
Pinned fields
Click on the next to a field label to start pinning.
Details
Details
Assignee
Sebastian Brudziński
Sebastian BrudzińskiReporter
Chongsun Ahn
Chongsun AhnStory Points
13
Time tracking
Components
Sprint
None
Fix versions
Priority
Time Assistant
Time Assistant
Created October 7, 2016 at 8:07 PM
Updated December 20, 2016 at 6:15 PM
Resolved December 20, 2016 at 3:23 PM
The endpoint for searching for facility type approved product endpoints should be redesigned and refactored, to create extensibility in approved products, and for cleaner design of the search endpoint.
Points to note:
/facilityTypeApprovedProducts endpoint stays but is strictly used for administration, management of facility type approved products.
The search endpoint for getting a list of approved products would be by facility, since most questions asked of reference data start with facility. So, a possible recommended endpoint would be GET /facilities/<facilityId>/approvedProducts, returning an approved product resource, which has maxMonthsOfStock, minMonthsOfStock, and emergencyOrderPoint.
If approved products need to be retrieved by program, the programId would be a query parameter. Ex: /facilities/<facilityId>/approvedProducts?programId=<programId>
The main benefit to doing this redesign and refactor is building extensibility into approved products. Currently approved products is only grouped by facility type (for this facility type, what are the list of approved products), but there may be a requirement in the future to get a list of approved products by something else, ex. requisition group. Because of this, the search endpoint should be designed in a generic way that allows for extensibility.
Acceptance Criteria:
The sub-tasks contain their own criteria. To confirm that this whole task is completed, please do a final QA test of the ability to initiate a requisition with the proper products based on facility and program.