Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

RequisitionService initiate improve facility and program check

Description

The facilityId and programId input are checked in the service method--preferable to check in the controller, since controller handles input validation. Also, error message seems to be incorrect if either id is null. The message should read something about "facility or program id not found", not "Requisition with such parameters already exists".

Acceptance criteria:

  • Move check to the controller and fix error message

Environment

None

QAlity Plus - Test Management

Checklists

Activity

Show:
Lucyna Laska
November 16, 2016 at 1:21 PM

All works.

When program, facility or both are null, message: "Facility and program must be specified when initiating a requisition" is returned.

More details in test case: https://openlmis.atlassian.net/wiki/x/CoC2BQ

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Time tracking

7h logged

Sprint

None

Fix versions

Priority

Parent

Time Assistant

Created October 13, 2016 at 9:12 PM
Updated November 22, 2016 at 4:30 PM
Resolved November 16, 2016 at 1:27 PM