Potential bug - "Error Occured" on convert to order

Description

When selecting two requisitions to convert to order, message "Error Occured" pops up.

openlmis-web.log attached.

Environment

Local build from dev branch a la 2/5/2016

Attachments

1

QAlity Plus - Test Management

Checklists

Activity

Josh Zamor 
February 26, 2016 at 10:40 PM

Left this at the simplest "fix": handle the exception.

Ben Leibert 
February 22, 2016 at 7:24 PM

I’m assigning this back to Josh, given that he’s back. (Yay!)

Beginning to get ramped up on this resulted in:

  • The exceedingly simple pull-request at https://github.com/OpenLMIS/open-lmis/pull/99. I used a pull-request because I’m not ultimately certain that the added checks are necessary. Specifically, I’m not sure what the delta is between our test/demo seed data and how we expect new users to configure a system. With our current test/demo seed data, however, the checks in this pull-request made for a more robust system.

Josh Zamor 
February 13, 2016 at 6:51 AM

This does seem to be an exception in sending emails, which doesn't seem like it should be a problem. Not sure what change caused this. Oddly it seems that RNR status changes RequistionService.sendRequistionsStatusChangeMail is no longer being called while the order change service still is. I'd like to track down why this change occurred and if it's leading to the issue where the flag to send mail is set for the supply depot...

I didn't have the time to track down the root change here or untagle the above question about no longer sending emails on RNR status changes. Throwing back in pool as I'll be OOF.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Sprint

Fix versions

Affects versions

Priority

Time Assistant

Created February 8, 2016 at 4:35 PM
Updated February 26, 2016 at 10:40 PM
Resolved February 26, 2016 at 10:40 PM