Column Emergency is not marked

Description

When my emergency requisition is e.g. authorized, it's available on the "Approve requisitions" view. Based on that view, I do not know if this requisition is emergency or not.

On the demo.openlmis.org, when emergency requisition is ready for approval, column "Emergency" is marked.

Acceptance Criteria:

when my emergency requisition is authorized and displayed on the "Approve requisitions" list (Requisitions->Approve), column emergency should be marked
when my emergency requisition is approved and ready to be converted to order (Requisitions->Convert to Order), it's displayed on the "Convert Requisitions to Order" view. Column emergency should be also marked
when I want to see the details of my emergency requisition (Requisitions-> View), column emergency should be marked
when requisition is not emergency, column Emergency should be empty.

Environment

None

Attachments

12 Dec 2016, 12:01 PM
12 Dec 2016, 12:01 PM
12 Dec 2016, 12:01 PM
12 Dec 2016, 11:59 AM
09 Dec 2016, 12:22 PM
09 Dec 2016, 12:22 PM
24 Nov 2016, 09:13 AM
24 Nov 2016, 09:08 AM

Confluence content

mentioned on

https://openlmis.atlassian.net/wiki/spaces/OP/pages/99287096/Backlog+Grooming+Sprint+15

QAlity Plus - Test Management

Checklists

Activity

Sebastian Brudziński
December 12, 2016 at 12:21 PM

Thanks @Lucyna Laska. I've opened https://openlmis.atlassian.net/browse/OLMIS-1465#icft=OLMIS-1465 for the bug you have mentioned. We currently do not associate new requisitions with a supervisory node, which is required during approval and convert to order steps and which results in the errors if such a requisition is approved.

Lucyna Laska
December 12, 2016 at 12:01 PM

All works.

When requisition is emergency, the emergency column is marked on:

"Requisitions->Approve" view

"Requisitions-> View" view

"Requisitions -> Convert To Order" view

(I created the emergency requisition for Family Planning. After approving, these emergency requisition appears on "Requisitions -> Convert to Order" view. The column "Emergency" is marked. However, earlier I had to assign the ID of SupervisoryNode using Rest Client to avoid server error message on UI.)

Sebastian Brudziński
December 9, 2016 at 2:28 PM

@Paweł Gesek @Klaudia Pałkowska This is an issue I mentioned today on Slack. Requisition is not associated with the supervisory node, which is required for the convertToOrder endpoint, hence the fail.

Klaudia Pałkowska
December 9, 2016 at 2:17 PM

@Paweł Gesek Ok.

Paweł Gesek
December 9, 2016 at 2:16 PM

This is the server error:

org.openlmis.requisition.service.referencedata.ReferenceDataRetrievalException: Unable to retrieve FacilityDto. Error code: 500, response message: {
  "timestamp" : 1481292927418,
  "status" : 500,
  "error" : "Internal Server Error",
  "exception" : "org.springframework.dao.InvalidDataAccessApiUsageException",
  "message" : "The given id must not be null!; nested exception is java.lang.IllegalArgumentException: The given id must not be null!",
  "path" : "/api/facilities/supplying"
}
	at org.openlmis.requisition.service.referencedata.BaseReferenceDataService.buildRefDataException(BaseReferenceDataService.java:168)
	at org.openlmis.requisition.service.referencedata.BaseReferenceDataService.findAllWithMethod(BaseReferenceDataService.java:138)
	at org.openlmis.requisition.service.referencedata.BaseReferenceDataService.findAll(BaseReferenceDataService.java:102)
	at org.openlmis.requisition.service.referencedata.FacilityReferenceDataService.searchSupplyingDepots(FacilityReferenceDataService.java:60)
	at org.openlmis.requisition.service.RequisitionService.getAvailableSupplyingDepots(RequisitionService.java:328)
	at org.openlmis.requisition.service.RequisitionService$$FastClassBySpringCGLIB$$a36d0853.invoke(<generated>)
	at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204)
	at org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:651)
	at org.openlmis.requisition.service.RequisitionService$$EnhancerBySpringCGLIB$$18b8a7f4.getAvailableSupplyingDepots(<generated>)
	at org.openlmis.requisition.web.RequisitionController.listForConvertToOrder(RequisitionController.java:472)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.springframework.web.method.support.InvocableHandlerMethod.doInvoke(InvocableHandlerMethod.java:221)
	at org.springframework.web.method.support.InvocableHandlerMethod.invokeForRequest(InvocableHandlerMethod.java:136)
	at org.springframework.web.servlet.mvc.method.annotation.ServletInvocableHandlerMethod.invokeAndHandle(ServletInvocableHandlerMethod.java:110)
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.invokeHandlerMethod(RequestMappingHandlerAdapter.java:817)
	at org.springframework.web.servlet.mvc.method.annotation.RequestMappingHandlerAdapter.handleInternal(RequestMappingHandlerAdapter.java:731)
	at org.springframework.web.servlet.mvc.method.AbstractHandlerMethodAdapter.handle(AbstractHandlerMethodAdapter.java:85)
	at org.springframework.web.servlet.DispatcherServlet.doDispatch(DispatcherServlet.java:959)
	at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:893)
	at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:968)
	at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:859)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:622)
	at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:844)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:729)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:292)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
	at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:316)
	at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.invoke(FilterSecurityInterceptor.java:126)
	at org.springframework.security.web.access.intercept.FilterSecurityInterceptor.doFilter(FilterSecurityInterceptor.java:90)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.access.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:114)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.session.SessionManagementFilter.doFilter(SessionManagementFilter.java:122)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.authentication.AnonymousAuthenticationFilter.doFilter(AnonymousAuthenticationFilter.java:111)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.servletapi.SecurityContextHolderAwareRequestFilter.doFilter(SecurityContextHolderAwareRequestFilter.java:169)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.savedrequest.RequestCacheAwareFilter.doFilter(RequestCacheAwareFilter.java:48)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.openlmis.security.ResourceServerSecurityConfiguration$1.doFilterInternal(ResourceServerSecurityConfiguration.java:56)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.oauth2.provider.authentication.OAuth2AuthenticationProcessingFilter.doFilter(OAuth2AuthenticationProcessingFilter.java:176)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.authentication.logout.LogoutFilter.doFilter(LogoutFilter.java:120)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.header.HeaderWriterFilter.doFilterInternal(HeaderWriterFilter.java:64)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.context.SecurityContextPersistenceFilter.doFilter(SecurityContextPersistenceFilter.java:91)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.context.request.async.WebAsyncManagerIntegrationFilter.doFilterInternal(WebAsyncManagerIntegrationFilter.java:53)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.springframework.security.web.FilterChainProxy$VirtualFilterChain.doFilter(FilterChainProxy.java:330)
	at org.springframework.security.web.FilterChainProxy.doFilterInternal(FilterChainProxy.java:213)
	at org.springframework.security.web.FilterChainProxy.doFilter(FilterChainProxy.java:176)
	at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:346)
	at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:262)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
	at org.springframework.web.filter.RequestContextFilter.doFilterInternal(RequestContextFilter.java:99)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
	at org.springframework.web.filter.HttpPutFormContentFilter.doFilterInternal(HttpPutFormContentFilter.java:87)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
	at org.springframework.web.filter.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:77)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
	at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:121)
	at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
	at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:240)
	at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:207)
	at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:212)
	at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:106)
	at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)
	at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:141)
	at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)
	at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:88)
	at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:522)
	at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1095)
	at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:672)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1500)
	at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1456)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
	at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
	at java.lang.Thread.run(Thread.java:745)

@Klaudia Pałkowska will you look into the issue?

Resize issue view side panel

Done

Pinned fields

Click on the next to a field label to start pinning.

Details

Assignee

Sebastian Brudziński

Reporter

Lucyna Laska

Story Points

Original estimate

1h 30m

Time tracking

1d logged

Components

Sprint

None

Fix versions

3.0

Priority

Major

Parent

OLMIS-1022 Develop UI for Requisition Application

Time Assistant

Created November 24, 2016 at 9:21 AM

Updated December 12, 2016 at 12:21 PM

Resolved December 12, 2016 at 12:02 PM