Requisition saving behaviour seems to have conflicting messages
Description
This was caused by trying to submit a requisition when the openlmisServerUrl is misconfigured. Even though this URL problem won't happen often, we want to deal with conflicting or duplicated alert messages in a better way.
Desired behavior: when you hit submit, authorize, reject or approve (any of the State Change buttons that have 2 API calls happening), we want to combine the 2 different resulting alerts into one single alert. If one API call passes and the second fails, just the error message alert should be displayed. We don't want to show 2 alerts (one green and one red). We also don't want 2 green alerts if both succeed. And if both fail, we don't want 2 red alerts. In all those cases, we want a single alert even though it is 2 API calls.
This desired behavior does not change If a user pushes "syncs to server" button they will receive an alert/notification of success.
Nick has suggestion about how the "alert service should be in the controller and not having 2 alert services separately in the services".
Environment
None
Attachments
1
image-2017-02-26-21-01-51-596.png
27 Feb, 2017
QAlity Plus - Test Management
Checklists
Activity
Paulina Borowa
March 9, 2017 at 10:37 AM
I think now its ok. I don't have problem with duplicated alert messages.
Brandon Bowersox-Johnson
March 2, 2017 at 9:30 PM
@Paweł Gesek@Nikodem Graczewski I'm not sure which team might pick up this ticket, but we revised the description and updated this.
Mary Jo Kochendorfer
March 2, 2017 at 9:23 PM
After further discussion with @Nick Reid and @Brandon Bowersox-Johnson, we will directly address the bug versus redesigning the auto-saving behavior. The bug is that two requests are being made and producing two alerts.
Mary Jo Kochendorfer
March 2, 2017 at 4:26 PM
(edited)
After Q&A, I think the most important thing is to have one alert at a time. However, it would be nice to discuss with @Nick Reid and if this is possible. Some questions, how do we know which one to show first? Would there need to be a queue?
Another option is to look into how the saving alerts are delivered. Could we have each cell or data entry display that it is saved? Clear visual cue like turning grey or another color...
Let's discuss soon on if we change the error alerts or the saving alerts to address the conflict.
Done
Pinned fields
Click on the next to a field label to start pinning.
This was caused by trying to submit a requisition when the openlmisServerUrl is misconfigured. Even though this URL problem won't happen often, we want to deal with conflicting or duplicated alert messages in a better way.
Desired behavior: when you hit submit, authorize, reject or approve (any of the State Change buttons that have 2 API calls happening), we want to combine the 2 different resulting alerts into one single alert. If one API call passes and the second fails, just the error message alert should be displayed. We don't want to show 2 alerts (one green and one red). We also don't want 2 green alerts if both succeed. And if both fail, we don't want 2 red alerts. In all those cases, we want a single alert even though it is 2 API calls.
This desired behavior does not change If a user pushes "syncs to server" button they will receive an alert/notification of success.
Nick has suggestion about how the "alert service should be in the controller and not having 2 alert services separately in the services".