Remove Products with Zero-Quantity Values from Order Export File
Description
QAlity Plus - Test Management
Checklists
Activity
This new feature introduces a new configuration option that can be set in a .env file like this:ORDER_EXPORT_INCLUDE_ZERO_QUANTITY=false
It does appear OpenLMIS version 3.1.2 is the version where this was added. (I've updated the fixVersion of this ticket.)
I think I found the pull requests ->
https://github.com/OpenLMIS/openlmis-config/pull/1
https://github.com/OpenLMIS/openlmis-fulfillment/pull/3
I am moving this ticket to done. I am not sure what release it was put into but I assume it was 3.1.2. @Brandon Bowersox-Johnson could you confirm?
@Ben Leibert do you remember what pull request this was folded back into core? I was trying to find the pull request. Thanks.
The Malawi team will implement this ticket and submit a pull request.
This request does make sense. I would like to suggest a few options and comment on overall Level of Effort as the global team considers this.
Fastest Option (~1-2 days effort): Make a global change that zero-quantity products and skipped products from the Requisition form do not get included in the Order (during Convert To Order). This option requires much less effort/time/cost, but we should make this change if and only if we believe that globally nobody wants their orders to include zero-quantity products.
Configurable Option (~3-5 days effort): Make a global configuration setting, as suggested in the ticket above, so that each instance of OpenLMIS could toggle whether it works the current way or this new way. This option requires more than 2X the effort to build, because we would have two versions of the logic, plus we would have a configuration option. This option does have long-term baggage/cost in terms of documenting and making sure both settings have automated test coverage so they are always guaranteed to work.
There could be even fancier options that have an Admin UI to toggle this setting on a screen (rather than in a settings file), or that have a per-program configuration. But I don't think we should ever pursue that complexity until/unless it is requested and warranted by in-country needs.
I added my own rough estimate of days of effort; these estimates do not reflect an official or group estimate from the core team. I just wanted to share this so people have a rough idea during the planning/consideration.
@Chongsun Ahn is the Fulfillment component lead for the global project, and he may have additional comments.
Details
Details
Assignee
Reporter
Labels
Components
Fix versions
Priority
Time Assistant
Open Time Assistant
Time Assistant

Raised by Malawi team
As a CMST clerk I need to export an order file that includes only the products and associated information that are being ordered so that I can maintain an efficient system and keep the orders manageable to review.
The Convert To Order operation creates a CSV file with products and requested quantities. Currently, products which have a requested-quantity of zero are included within this CSV file. For Malawi, at least, they should not be.
Acceptance criteria:
Export files created by the convert to order function do not include commodities with approved quantities of 0
Skipped products are not included in the export files
All functions where requisitions/orders are viewed (during approvals, view requisitions, view orders, printing, reports) do not exclude commodities with requested/approved quantities of 0
Completion criteria:
A configuration-option has been added which determines whether such products should be included within the CSV file output by the ConvertToOrder operation.
A pull-request to introduce this option into the core product has been created.