SoH Incorrect and NaN Error

Description

#1 SoH calculation is REALLY off.

  • after entering in received amount, SOH is concatenating the Beg Bal with Received Amount (WHAT???)

#2 Unclear what NaN is being thrown when only an integer is being entered.

  • it looks like when you enter in Beg Bal, NaN is show

  • after entering received quantity it goes away

Environment

None

Attachments

1

QAlity Plus - Test Management

Checklists

Activity

Show:
Lucyna Laska
April 28, 2017 at 1:04 PM

Okay so I double checked the issues mentioned in AC and comments on Chrome and Firefox. The problems with NaN and calculations for SoH do not occur anymore. I also checked if it's possible to enter symbols into the inputs and only positive numbers are allowed.

Chongsun Ahn
April 26, 2017 at 10:59 PM

Additionally I am able to enter symbols like #$% into the inputs as well, Firefox only.

Mary Jo Kochendorfer
April 26, 2017 at 10:55 PM

, unfortunately when I'm in firefox I cannot enter the number 9 into ANY of the inputs! That is really strange. Sadly I feel we may need to discuss rolling back this improvement disappointed face Perhaps you and the team can chat tomorrow to discuss options.

Mateusz Kwiatkowski
April 26, 2017 at 7:57 PM

Probably is caused by this commit. The intention was to place `type="number"` attribute in positive integer directive to avoid repeating this in html elements, but seems that it does not work with some calculations on product grid. I will fix that in a moment.

Chongsun Ahn
April 26, 2017 at 7:19 PM

Could it be from this commit (https://github.com/OpenLMIS/openlmis-requisition-ui/commit/8b83da46a60a3a4a910fb4c8f48c89bc34bfc324) in the openlmis-requisition-ui repository? MJ said this started happening this morning and I see this commit was done earlier today.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Original estimate

Time tracking

3h logged

Components

Sprint

None

Fix versions

Affects versions

Priority

Time Assistant

Created April 26, 2017 at 6:54 PM
Updated April 28, 2017 at 1:09 PM
Resolved April 28, 2017 at 1:04 PM