Create modal view configuration

One more thing. AngularStrap modal doesn't support nested resolves and to add them you need to follow the pattern below. With modalStateService we're getting the default stateProvider resolve behavior as the whole boilerplate code is done by that service.

This

becomes this

Here's the example of the service usage

vs without it

The thing with parent resolves is that they are not supported by angularstrap, so to pass them to the modal you actually need to inject it in the onEnter method, which then uses it is the modal resolve. With my implementation you simply define the parent resolves you want to have injected into your controller without writing that boilerplate code. So, in a way, my implementation fixes that gap rather than breaks it. I was trying to inject the parent resolves into the controller without this property, but I couldn't get it done, because I didn't have parent state definitions there, you can't actually pull them from $stateProvider (sadly). Well not in an easy way at least.

Also I'm not sure what's the difference between calling a proper service and adding a 'layout' property to the state definition. We're still passing information about the markup with the route declaration. Wouldn't that be basically them but in a slightly different form?

No worries, let's keep this ticket – and let's leave the existing implementation for now (as I don't really want to refactor working code that is DRY) – lets just not spread the implementation until later

Yes, I think adding a 'layout' property to the state definition is a solid and decoupled way to approach this

Parent resolves: Yes

Unfortunately I don't think we'll be able to pull this ticket this Sprint.

By the route configuration approach you mean adding a 'layout' property to state definition and make it accept a 'modal' value?

About the broken functionality, do you mean the parent resolves?