Cannot search orderables and supervisory nodes with access token provided by query params

Description

Steps to reproduce:
1. Get an access token for any user
2. Call /api/orderables?code=bcg20&access_token=token_from_step_1

Expected Behavior:
List of matching orderables is returned

Actual:

Acceptance criteria:

  • I can search orderables by providing access token with query params

  • When provided any wrong query param, message is valid (it should say orderables, not facilities.)

  • check that similar issue with /api/supervisoryNodes is fixed

Environment

None

QAlity Plus - Test Management

Checklists

Activity

Paweł Albecki 
April 9, 2018 at 12:05 PM
(edited)

I agree with Mateusz. Hovewer, supervisoryNodes and orderabes search reuse the same code, so no additionall work will be required. (QA should check it though)

Mateusz Kwiatkowski 
April 9, 2018 at 11:09 AM

I think that this is an issue with this endpoint only. We are throwing exception here when user sends unrecognized parameter, we are omitting page, size and sort but we forgot about acces_token also /api/supervisoryNodes probably need fixing.

Łukasz Lewczyński 
April 9, 2018 at 10:58 AM

Is it possible that we will need to fix this in other services?

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Original estimate

Time tracking

6h logged2h remaining

Sprint

Fix versions

Affects versions

Priority

Time Assistant

Created April 9, 2018 at 9:57 AM
Updated April 24, 2018 at 8:42 PM
Resolved April 16, 2018 at 10:48 AM