Fix randomly failing LocalDatabase unit tests

Description

Example build: http://build.openlmis.org/job/OpenLMIS-report-ui-pipeline/job/master/38/

Acceptance Criteria

  • The test no longer fails randomly.

  • Stop keeping the linked build forever on the Jenkins.

Activity

Chongsun Ahn 
March 25, 2019 at 9:41 PM

not sure. They might be consistent, as every test is getting it. I'm a bit stumped with how to redo the tests, and some other work has come up with higher priority, so I'm going to move this back to ToDo.

Nikodem Graczewski 
March 25, 2019 at 4:30 PM


We could mock PouchDB but we need to make sure that we're using JavaScript promises (not AngularJS ones) when we do so.

Are those timeouts consistent or are they random like they are now?

Chongsun Ahn 
March 25, 2019 at 3:46 PM

It is looking more and more likely we'll need to do something besides the first option. I upgraded Jasmine to 2.x and the tests are still returning an error with a timeout from PouchDB. We either need to have a wrapper that we can mock, or we mock PouchDB itself.

Chongsun Ahn 
March 21, 2019 at 8:49 PM

So there is no way to create a mock of PouchDB that mocks its calls? We don't really want to run through the PouchDB logic, but just get return values to test our wrapper.

Chongsun Ahn 
March 21, 2019 at 8:44 PM

I am having a hard time finding an appropriate third party wrapper for PouchDB. As a result, I am leaning towards upgrading Jasmine. However, I am having a hard time finding where to do that. Would that be in the dev-ui image? I have tried to update it to 0.2.x, but an individual UI repo doesn't seem to take.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Original estimate

Time tracking

2d 1h 30m logged6h 30m remaining

Components

Sprint

Fix versions

Priority

Time Assistant

Created September 11, 2018 at 3:19 PM
Updated May 29, 2019 at 8:24 AM
Resolved May 29, 2019 at 8:24 AM