Fulfillment service references demo data Stock reason by default

Description

The fulfillment service is referencing the Stock reason "TRANSFER IN" in its application.properties that only exists in the demo data of the Stock management - https://github.com/OpenLMIS/openlmis-fulfillment/blob/master/src/main/resources/application.properties

This property can be easily overwritten by an env variable, but we should not default to something that doesn't exist on a regular production instance.

Recommendations:

  • Move TRANSFER_IN to seed/bootstrap data or resign from the default value in application.properties and force implementations to set it up appropriately

  • Consult this with the tech committee before implementing so we agree on the solution

Environment

None

Activity

Jakub Jakubowski 
July 16, 2019 at 9:05 AM

I checked, the TRANSFER_IN stock reason is added.

Sebastian Brudziński 
July 16, 2019 at 8:09 AM

Can you start the ref-distro with the production flag only and verify that TRANSFER_IN stock reason is added? There should be a total of 5 bootstrap stock reasons added with the production flag.

Sebastian Brudziński 
July 11, 2019 at 12:05 PM

I don’t think this would be too much of an effort. Some additional thoughts to the discussion on tech committee:
Re-translations: they can be done easily, since reason is referenced by UUID. Nothing is affected by name update
We follow the same approach for requisition, so this doesn’t add any complexity if we want to move away from this (we will have to figure out the way for requisitions too).

Let me know if you have other thoughts.

Josh Zamor 
July 10, 2019 at 2:47 PM

Could we investigate how much effort would be involved if we want to switch away from this approach after it’s been released?

Sebastian Brudziński 
February 11, 2019 at 2:08 PM

I've updated this with recommendations, but we should still bring this to the tech committee with a proposed solution before implementing.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Story Points

Original estimate

Time tracking

2d 6h 30m logged1d 1h 30m remaining

Components

Sprint

Fix versions

Priority

Time Assistant

Created October 9, 2018 at 2:38 PM
Updated August 22, 2019 at 2:09 PM
Resolved July 16, 2019 at 1:32 PM