Add 'supportedProgram' entity to GET /api/facilities endpoint

Description

While working on fixing particular report on Malawi implementation it is realized that some of the data coming from GET /api/facilities is missing therefore there are problems with processing some reports.

On NiFI level there is special group of jobs responsible for fetching ReferenceData. One of the most important endpoint is GET /api/facilities. According to this schema https://github.com/OpenLMIS/openlmis-referencedata/blob/ea2d0516dd62cadbb6af3e8ac224d82e3bddd442/src/main/resources/schemas/facility.json#L59 there is possibility to have returned ‘supportedPrograms' but currently API GET api/facilities doesn’t show such data in the response body. Without this ‘supported programs' we cannot count properly some of the reports related to 'Reporting Rate and Timeliness’.

Acceptance criteria:

there should be an endpoint available to get a list of facilities and their supported programs
changes cannot affect existing solutions.

To do:

In the FacilityController class, create a new endpoint;
GET api/facilities/full
It should return a list of FacilityDto, which contain a list of the facility's supported programs

Attachments

Bez tytułu.jpg

21 Mar, 2023

Checklists

Activity

Show:

Aleksandra Hinc

March 21, 2023 at 7:39 PM

(edited)

Hi @Szymon Radziszewski , I’ve checked this issue using Postman app.

endpoint GET /api/facilities returns a list of facilities and their supported programs with status 200;
No other issues found;

Szymon Radziszewski

March 21, 2023 at 5:59 AM

@Aleksandra Hinc The change has been deployed to UAT, could you check if everything is working properly?

Nikola Laskowska

March 20, 2023 at 1:10 PM

@Szymon Radziszewski code is merged, please make sure that the changes are on UAT ready for testing. Also please update the description to clearly say what is desired as a result of this task.

Piotr Wargulak

March 20, 2023 at 8:49 AM

@Szymon Radziszewski Looks fine

Szymon Radziszewski

March 17, 2023 at 4:21 PM

After the changes made as part of OLMIS-3773, there was no endpoint returning all Facility records (which contains the supportedPrograms field required by @Seweryn Niedzielski). I created a new endpoint like /api/facilities/minimal returning a list with full representation of Facilities.

Resize issue view side panel

Unresolved

Pinned fields

Click on the next to a field label to start pinning.

Details

Assignee

Szymon Radziszewski(Deactivated)

Reporter

Seweryn Niedzielski

Labels

Original estimate

1d 4h

Time tracking

1d 4h 30m logged

Components

Reference Data

Fix versions

3.15

Priority

Trivial

Time Assistant

Created February 13, 2023 at 3:48 PM

Updated March 21, 2023 at 7:40 PM