Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Saving an empty Add Source of Fund modal makes it impossible for the user to take any further action

Description

Trying to save an empty modal, no error message appears, the page is grayed out and nothing can be done on it

Precondition:

  1. User is logged in as Administrator

  2. Add period in BUQ → Prepare BUQ → select period → prepare

Steps to reproduce:

  1. Go to BUQ → Create / Authorize Forecasting

  2. Click Forecast button

  3. Click Add Source of Fund button

  4. Click Save button

Expected Result:

Validation for fields that need to be completed appears. The user has the opportunity to continue to use the site and correct errors

Actual Result:

Error does not appear, page is grayed out, unable to work on page

VIdeo:

https://jam.dev/c/c757413b-b6d2-4029-b153-72c810e398f5

Environment

None

Checklists

Activity

Show:

Dominik NogaOctober 24, 2024 at 10:10 AM

could you please verify if this solution suits you? You can check it on the test instance.
https://test.openlmis.org/
If there will be a problem with opening the BUQ page. Log out, clear cache and log in again.

Aleksandra CiesińskaOctober 24, 2024 at 7:31 AM

looks good, approved

Dominik NogaOctober 24, 2024 at 7:27 AM

The second PR is also ready. could you also review?

Dominik NogaOctober 24, 2024 at 6:58 AM
Edited

I have found the source of the problem. It is a changed prop name in the react modal component. From ‘children’ to ‘body’. Now the components that are using the old name do not display a modal content causing the issue with the grey screen. The fix will require 2 pull requests.
1. Changing the prop name back to ‘children’, because only one place uses the new name. (Fix in ui-components repo)

  1. Changing the prop name in requisition-ui repo from 'body' to ‘children’

could you please revuew the first PR?

Unresolved
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Original estimate

Time tracking

4h logged1h remaining

Priority

Time Assistant

Created October 23, 2024 at 11:37 AM
Updated November 29, 2024 at 2:15 PM