Page Comparison

Date

14 Jun 2017

Item

Notes

Minimizing responses for state change endpoints

Data from submit/authorize/approve/skip/reject endpoint endpoints minimized by using a basic dto - this should not impact UI calculations after some small changes on the UI side, so we decide decided that we can merge these changes - there shouldn't be any real issue with the client (UI).
This does not change much with the UI, except the offline requisition will no longer be overwritten when changing status
There is some concern about the UI calculations not beiing being sent to the backend for validation (the calculated fields are getting nulled) - but this commit does not really change things with this, currently the user is shown the UI calculations as well (they are not sent to the backend).
We weren't sure if backend validates calculation, bust but likely so - if this is the case, the UI should not set calculated values to null before sending. This would make us more confident in the UI calculations.

Non full supply products

Non full supply products are now fetched with a single call instead of looping through them and fetching them one by one - this is the only change to them that was made (except the above response trimming). Apparently the performance gain is from 30s to 5s.
The above change is a PR from Jakub Kondrat - he is doing last fixes for it
Caching the orderables might be a future improvement to this
Malawi performance tickets are outdated and do not reflect the work being done in them
Comment by Jakub Kondrat that Josh Zamor is asking about is outdated, Jakub Kondrat will respond in the ticket

Nikodem Graczewski (Unlicensed) to create a ticket for making the UI send calculated values to the backendd, if the latter support validating these calculations (we believe it should) (
Jira Legacy
server JIRA (openlmis.atlassian.net)
columns key,summary,type,created,updated,due,assignee,reporter,priority,status,resolution
serverId 448ba138-230b-3f91-a83e-16e7db1deed1
key OLMIS-2702
)
Merge Jakub Kondrat, Łukasz Lewczyński (Deactivated), Weronika Ciecierska (Unlicensed) PRs
Malawi team to test performance after all the changes merged
Jakub Kondrat to clarify on outdated comment in MW-304
Łukasz Lewczyński (Deactivated) to check if backend validates calculated values