Skip a product lineItem

Description

Description
As a storeroom manage, who is a submitter or an authorizer, I should have the ability to skip or unskip selected products in an R&R. Skipping a product makes the product visibly greyed out and non editable, where as unskipping it would turn it back to life and editable. Once the R&R which has skipped products is authorized then all the data values of the skipped products have to be nulled.

Same behavior for both Regular and Emergency R&R

Also, this impacts printing create a new story to clean up so that a user can either print all products or hide the skipped ones.
Also, we need to address adding products back if skipped previously.

This ticket is an API ticket for implementing the ability to skip product line items in the Requisition API. The corresponding UI task is OLMIS-1084.

Acceptance criteria for API part

  • Skipping/Unskipping line items is possible only when requisition is INITIATED or SUBMITTED

  • Skipping line item is indicated by the "skipped" flag on the requisition line item

  • When authorizing the requisition with skipped line items, all the values of the skipped line item must be nulled

  • Skipping is only possible if the skip column is enabled in the requisition template

  • This works the same way for regular and emergency requisitions

  • Skipped line item can be submitted/authorized/approved with empty user input fields

  • Calculations are not performed on skipped line items

Acceptance Criteria

When

Then

Submitter or authorizer logs in to a R&R where skip products has been turned on in the master template for the program

A skip option is available for the individual products, along with a skip all/ unskip all check box at the top of the column

User clicks on the check box for skipping a product

Grey out the product and make it uneditable

User clicks on the check box for a skipped product

Turn back the product as "normal" and make it editable once more

user clicks on the skip all check box

Skip all products on the current R&R page

User unskips one product after skip all has been done

unskip that product and unckeck the skip all check box

user skips one or more products

The cost of the skipped product(s) is omitted from the total cost for the R&R

User unskips one or more skipped products

The cost of the unskipped product(s) is incluldd in the total cost

Attachments

5
  • 11 Jan 2017, 02:19 PM
  • 28 Dec 2016, 01:09 PM
  • 28 Dec 2016, 01:09 PM
  • 27 Dec 2016, 12:29 PM
  • 18 Nov 2016, 04:19 AM

QAlity Plus - Test Management

Checklists

Activity

Paulina BorowaJanuary 13, 2017 at 1:48 PM

I tested case reported by Weronika on regular and emergency requisition and now I can submit/authorize/approve with empty user input fields.

Weronika CiecierskaJanuary 11, 2017 at 2:19 PM
Edited

How to reproduce bug:

  • Go to the family planning initiated requisition

  • Make field 'Total Consumed Quantity' empty in one of the products

  • Mark this product as skipped

  • Try to submit requisition

  • You should get error from API: "Cannot submit requisition: 6167e65c-6f56-4aeb-bff5-fdfe84e01a21, requisition fields must have values."

Weronika CiecierskaJanuary 11, 2017 at 2:12 PM

I am reopening this ticket because of the errors that I found during work on OLMIS-1084.
I added two acceptance criteria:

  • Skipped line item can be submitted/authorized/approved with empty user input fields

  • Calculations are not performed on skipped line items

Paulina BorowaJanuary 10, 2017 at 2:59 PM

All works.
More details in test case:
https://openlmis.atlassian.net/wiki/x/AwCLBg

Paulina BorowaJanuary 4, 2017 at 10:56 AM

This acceptance criteria doesn't work correctly:

  • Skipping is only possible if the skip column is enabled in the requisition template
    When I have in my requisition template disabled skipped part I can still set skipped to true in my newly created requisition.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Story Points

Original estimate

Time tracking

1w 3d 4h logged

Components

Sprint

Fix versions

Priority

Time Assistant

Created November 18, 2016 at 4:19 AM
Updated March 1, 2017 at 8:39 PM
Resolved January 13, 2017 at 1:48 PM

Flag notifications