[UI] Submit physical inventory
Description
Attachments
relates to
QAlity Plus - Test Management
Checklists
Activity
@Shiyu Jin, Josh/Chongsun/I watched the video and have the following comments :
1. We agree with Brandon's comment about the error message improvement by giving more detail.
2. Please indicate that the date field is required with a " * " (Date * )
3. Something strange was happening with the resizing of the column widths. For some reason it started larger and resized smaller. Not sure why that happened.
4. In terms of the signature field, @Brandon Bowersox-Johnson I had made the suggestion on the PC meeting for the Adjustments to be confirmed with a statement incorporating the username versus the signature text box. I believe Auditors may want a text box (and some day eSignature) here but perhaps we can add the statement underneath the Signature saying, "Physical Inventory submitted by <username>".
@Wei Zhang Yes. If anything causes the back-end API save to fail, it will help the end-user to see what the error message is from the API.
@Brandon Bowersox-Johnson
For your first suggestion above. You mean no matter what kind of error is catch in the back-end API are displayed on the UI page?
Hi @Shiyu Jin and @Wei Zhang I watched the video, and this looks very good!
I have two small suggestions:
When the physical inventory fails to submit (because of back-end API error, as in the last scenario in the video), I suggest we show the user the detailed error message from the API. So the red box could say this: "Physical inventory failed to submit: ______" where the API's error message goes in the blank.
The signature field could be replaced with a statement to tell the user they are digitally signing it by clicking Confirm. I believe @Shiyu Jin had suggested this during conversations about the Adjustment UI. Perhaps we don't want to change it because we have already built it this way, which is fine. But I wanted to share this comment in case you are talking about changing the Signature fields across the whole Stock UI.
@Mary Jo Kochendorfer is organizing a team session for Team ILL to watch all the new videos during our Thursday work day.
Hi @Wei Zhang In that case, we do have the ability to have error messages pop up on screen that do have one or more variables inside the message.
Here is an example where this happens from a back-end API error response:
https://github.com/OpenLMIS/openlmis-auth/blob/master/src/main/resources/messages_en.properties#L26 (error message key)
https://github.com/OpenLMIS/openlmis-auth/blob/master/src/main/java/org/openlmis/auth/service/PermissionService.java#L49 (throwing the error)
However, I can't find an example of where the UI code has variables inside its messages. But I believe we do support that too (on the UI, not just in APIs).
CC @Pengfei Cui
But regardless of all this, the message "Physical inventory has successfully been submitted" is probably fine for this use scenario. So if you use that message for now, it's fine for this situation.
Details
Details
Assignee
Reporter
Labels
Story Points
Sprint
Fix versions
Priority
Major
Time Assistant
Open Time Assistant
Time Assistant
This is split from the OLMIS-2086
As a storeroom manager
I want to submit my physical inventory
so that I can record and report the physical inventory to my managers
Scope in:
Validation for mandatory fields;
Sync up physical inventory to server;
Scope out:
View completed/submitted physical inventory;
Acceptance Criteria:
Given I am on the physical inventory list page and I have filled all physical inventory fields when I click the 'Submit' button then it will pop-up a window within date picker and signature field;
Given I am on the physical inventory list page and I leave some physical inventory fields blank when I click 'Submit' button then those blank fields are highlighted and I stay the same page without the pop-up window;
Given I am on the pop-up window, date picker is the mandatory field and its default value is today(current date) while the signature field is free text and optional;
Given I am on the pop-up window, I cannot choose a future date;
Given I am on the pop-up window when I choose a past date and click 'Confirm' button then it will direct me to the SOH summary page within a message on the top says 'Physical inventory for <facility name> and <program> has successfully been submitted';
Given I am on the pop-up window when I click 'Confirm' button but there is an error then I will stay at the draft physical inventory page within a message on the top says 'Submit has failed' 'Physical inventory failed to submit';