Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Unrestrict GET operations on some reference data resources

Description

Resources affected:

  • facilities search

  • geographic zones

  • geographic levels

  • facility types

  • roles

  • periods

  • schedules

  • programs

  • orderables

  • tradeitems

  • commodity types

  • FTAPs

  • ISAs

  • lots

  • orderable display categories

  • requisition groups

  • supervisory nodes

  • supply lines

Note: These changes were made and released in OpenLMIS 3.2.1. But certain related integration tests were not added back until 3.3.0. So the source code changes tagged with this ticket number span two different releases.

Security note: These changes make lists of key resources (EG, facilities, orderables) available for download by any client with a valid token. This means a valid user login is required (the resources are not available publically).

Confluence content

mentioned on

QAlity Plus - Test Management

Checklists

Activity

Show:
Josh Zamor
November 14, 2017 at 5:20 PM

This looks good to me, and I can't see how this would be QA'd as the change here was just to add back some integration tests (which all passed). Moving to Done.

Brandon Bowersox-Johnson
November 1, 2017 at 9:30 PM

We probably want to put this back on grooming to get it done right away after 3.2.1 (before we forget). The coding work was already done before 3.2.1, but the tests are not finished. The ticket was going to roll over and instead we removed it from the sprint, so it is sitting in the Backlog in In Review status.

Technical Notes:
There were integration tests that got removed during the work on this ticket (the 10 commits in sprints 35 and 36). We need to add the tests back and change them to HTTP 401s instead of 403s.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Labels

Time tracking

15m logged

Components

Sprint

None

Fix versions

Priority

Time Assistant

Created September 25, 2017 at 3:42 PM
Updated November 16, 2017 at 6:47 AM
Resolved November 14, 2017 at 5:20 PM