Change line items from sets to lists

Description

We do care about the order of the entries for the line items (eg. RequisitionLine), therefore we shouldn't use Set, but a List instead.

Attachments

1

QAlity Plus - Test Management

Checklists

Activity

Przemysław Studziński 
August 26, 2016 at 3:50 PM

Hi ,
I wrote a report about this.
Please look:

Josh Zamor 
August 23, 2016 at 3:44 PM

I ran across this so I thought I'd add some notes from when I more actively built with the JPA:

It used to be true that Hibernate (which is currently backing our JPA) treated a List as an unordered collection. Meaning if you didn't specify an orderby type of attribute on the relationship, and use the DB for ordering, a List wouldn't necessarily have any guarantee of insertion order. This would need to be verified with today's Hibernate and JPA. Also a Set isn't necessarily unordered, e.g. LinkedHashSet and TreeSet in the collections api can be ordered sets, insertion and natural respectively. However I do recall that mapping Sets with JPA and Hibernate had more tricky spots than I can fully remember now. Maybe it's improved.

Done
Pinned fields
Click on the next to a field label to start pinning.

Details

Assignee

Reporter

Time tracking

2d 30m logged

Fix versions

Priority

Time Assistant

Created August 12, 2016 at 9:46 PM
Updated November 12, 2016 at 11:36 AM
Resolved August 23, 2016 at 11:36 AM