2019-03-19 TC Meeting notes

2019-03-19 TC Meeting notes

Date

Mar 19, 2019

7am PST / 3pm CET

Meeting Link

https://zoom.us/j/211353423

Attendees

  • @Sebastian Brudziński (Moderator)

  • @Paulina Buzderewicz

  • @Mateusz Kwiatkowski

  • @Josh Zamor (Deactivated)

  • @Wesley Brown

  • @Chongsun Ahn (Unlicensed)

  • @Elias Muluneh

  • @Łukasz Lewczyński (Deactivated)

  • @Nikodem Graczewski (Unlicensed)

  • @Klaudia Pałkowska (Deactivated)

 

Discussion items

Time

Item

Who

Notes

Time

Item

Who

Notes

5m

Agenda and action item review

@Sebastian Brudziński

 

 

10m

App caching: next steps

@Paulina Buzderewicz

  • Show the results of PoC

    • There are some nice performance improvements (retrieve supervisory node from 4.5s to less than 0.1s)

  • Talk about the next steps

10m

Angola team contributions

@Sebastian Brudziński

  • Pull requests vs. push to master & code review

15m

Feature flags

@Mateusz Kwiatkowski

  • How was it?

5m - if enough time

Changes to the dev process after 3.6 release

@Wesley Brown

 

5m

package lock files

@Chongsun Ahn (Unlicensed)

 

Notes

App caching:

  • PoC implemented

  • Good performance improvement for supervisory node retrieval (4.5s to 0.1s)

  • Next steps?

    • Worth looking into build-in caching support for Spring Boot

    • Still need to investigate db caching

  • This was implemented on the controller layer (caching DTOs)

 

Angola contributions:

  • We will probably be getting way more contributions to core than we used to in Malawi

  • We will work on many core tickets

  • Josh: we should always get a sign-off from core to implement something; by default go through the tech committee; pull requests just for small changes/tweaks

  • Wes: consider talking about how we treat external contributions in general

  • What about testing changes from the external team?

    • We certainly might have a gap here

    • Rely on close collaboration with the teams to ensure we have the software properly tested (agree with Angola who is testing the change and how)

  • Consider having a separate call about this (maybe with the Angola team?)

 

Feature flags:

  • Approach to removing feature flags (when?)

 

Package lock files concerns:

  • dev-ui was updated to support the package-lock files

  • some of the services are not using them and package-lock files are ignored

  • why do we have package-lock file in .gitignore?

    • the file changed with each build

 

Action Items

@Sebastian Brudziński to schedule a call with @Josh Zamor (Deactivated) and @Paulina Buzderewicz to talk about the concerns and next steps for App caching
@Mateusz Kwiatkowski to schedule another call with @Josh Zamor (Deactivated) or move it to the next tech committee to talk about feature flags more
@Chongsun Ahn (Unlicensed) to create a ticket to unignore the package-lock

Comments

OpenLMIS: the global initiative for powerful LMIS software