Backlog Grooming Sprint 27

Objective: to continue addressing critical bugs (performance and major UI issues)

Reference UI

NR: These will make working with the UI easier

• OLMIS-2589 - Change grunt watch to watch all App directories To Do
• OLMIS-2583 - Change grunt watch to rebuild sections of UI Done

• OLMIS-2509 - Table container and sticky columns leave white space when screen is expanded Done  - NR: Is this a dupe of OLMIS-2328
• OLMIS-2439 - Skip all/none should effect line items on all pages Done
• OLMIS-2573 - Form inputs in tables don't show error message when focused Done  - NR: This should be fixed in OLMIS-1693
• OLMIS-2572 - Table column hover headers to have larger hit area Done

• OLMIS-2444 - Add "button-add" class to all add buttons Done

• OLMIS-1189 - Product grid text fields "select all" on input focus To Do

• OLMIS-1889 - Check the user rights before displaying the page Backlog
• OLMIS-1925 - Design select all to be consistent Done (Team ILL)

Stretch:

• OLMIS-249 - Calendar localization Done  - NR: Angular strap has hard coded string, might need another library

Requisition

Working on 3.1.5-SNAPSHOT (the incoming changes due to performance issue will most likely result in version 4.0.0 being the case)

Brandon Bowersox-Johnson to create a ticket to (coordination and fixes on both the UI and endpoints and even other things) to either reduce requests and decreased payload. Brandon Bowersox-Johnson were you able to create this ticket, is it either 2565, 66, 84, or 33?

• OLMIS-2565 - UI reuse DTO from requisition initialize Canceled  (Which Malawi bugs does this address? A: Requisition load time)

• OLMIS-2566 - Requisition search endpoint returns smaller requisition DTO Done  (Q: Solution for this will probably be the same as for OLMIS-2584 - Convert to Order page too slow/causes blank errors Backlog ) (Which Malawi bugs does this address? A: Requisition view/approve/convert to order)
  Make sure to reference the related Malawi bugs  OLMIS-2584 - Convert to Order page too slow/causes blank errors Backlog

• OLMIS-2584 - Convert to Order page too slow/causes blank errors Backlog
• OLMIS-2533 - Request payload too big for saving/retrieving requisitions and converting to order Done  (Q: proposed solution in comment)
  (In addition to what Łukasz included in his daily report on timeouts - we have increased the maximum execution time, but this is a temporary workaround. The requests already take too long time for certain things (especially reports since they usually require a lot of data). The root reason is requisition related endpoints returning a lot of unnecessary data - I've created a ticket for this in core (OLMIS-2533) but if it becomes problematic quickly we may need to fix it ourselves and contribute this to the core product - Sebastian 5/17)
  • Remove previous requisition history
  • Do BA work to decide what is actually needed (where/when) 
  • FYI, the Malawi logged bugs  MW-164 , MW-165 , MW-166 , MW-167 , MW-171.
• OLMIS-2522 - Message key appears when my facility is removed Done
• OLMIS-2514 - Supervision role not enforced on requisition approve endpoint Done
• OLMIS-2530 - Pagination stopped working on the View Requisition view Done
• OLMIS-2193 - Fill testing gap for changing the approved quantity in in_approval state To Do
• OLMIS-2531 - Wrong error is displayed when supplying depot is not selected Done
• OLMIS-2543 - Make UI error box display API error messages Done  (Brandon Bowersox-Johnson, does this need further directions?)

• OLMIS-1133 (NR: Can we make a ticket to gather requirements/design/socialize this issue?)

Reference Data

Will be working towards 6.0.1

OLMIS-2574 - Document consumer contract test To Do

OLMIS-2536 - Missing check if facility supports program Done  This endpoint should filter the facilities (this is a dependency for MW-170)

OLMIS-2494 - Role Rights Error message doesn't follow standard Done

OLMIS-2277 - Email address format not validated Done  (Q: Do we want front-end validation? A: Yes)

OLMIS-2292 - Document user Create/Update and Read endpoints Done

OLMIS-2385 - Update Role pages - label change Done  (very small)

OLMIS-2384 - Edit User text label update Done  (very small)

OLMIS-2495 - User page: Change Links to Buttons Done

Stretch:

OLMIS-2552 - Paginate all Reference Data search endpoints To Do (likely shouldn't pick this up, if we did, Reference Data would be working on v7.0.0 - the next major release)

Fulfillment

OLMIS-2551 - Convert to Order rollbacks whole transaction even if only one order fails to get created Done

OLMIS-2532 - For supervised facility, Manage PODs view always display the previously facility Done

Platform

OLMIS-2147 - Show back-end API errors in users language Backlog

Stretch Goal: 

Stock Management: Change it from Hibernate to Flyway before our next/non-beta release (or move this to Grooming 28?? Team ILL)

Stretch:

OLMIS-2574 - Document consumer contract test To Do

Reporting

Roll-over from last sprint.

Issues Discovered During Malawi UAT

OLMIS-2584 - Convert to Order page too slow/causes blank errors Backlog

OLMIS-2585 - Non-full supply Product dropdown search is broken Done

OLMIS-2586 - Dropdown for losses and adjustments reason does not close Canceled

OLMIS-2587 - Initiate LMIS form search bug when changing from regular to emergency Canceled  (Q: As far as we remember this was the desired behavior. Do we want to clear the table when changing requisition type/any input value?) A: Waiting for OLMIS-2554

OLMIS-2588 - Sticky filter option dropdown Done  (Q: What is the status of this ticket?) A: Will be dead after OLMIS-2476

OLMIS-2548 - Loading spinner does not show after re-authenticating Done

Team ILL

OLMIS-2578 - Hold ODK joint session Done

OLMIS-2581 - Create stories for vaccines CCE Done

OLMIS-2580 - June SOWs Done

OLMIS-2582 - Product testing Done

Contract testing dev-wide short presentation (see a few ideas on retrospective)

15-minute design meetings after stand-up (do not need a ticket for this; but we will pilot this idea during Sprint 27)

Stretch goals:

OLMIS-2590 - Create Stock Management tickets for vaccines To Do

Performance Testing of key endpoints (find the ticket for it)

Refactor so we can accept the batch approve page in requisitions